From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Don't pretend ips is always enabled on BDW. Date: Mon, 7 Jul 2014 18:13:47 +0200 Message-ID: <20140707161347.GN5821@phenom.ffwll.local> References: <1403881925-10916-1-git-send-email-rodrigo.vivi@intel.com> <1404128701-22588-1-git-send-email-rodrigo.vivi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by gabe.freedesktop.org (Postfix) with ESMTP id C999889E06 for ; Mon, 7 Jul 2014 09:13:40 -0700 (PDT) Received: by mail-wi0-f176.google.com with SMTP id n3so16191677wiv.3 for ; Mon, 07 Jul 2014 09:13:37 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: Intel Graphics Development , Paulo Zanoni , Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org On Mon, Jun 30, 2014 at 04:17:00PM -0300, Paulo Zanoni wrote: > 2014-06-30 8:45 GMT-03:00 Rodrigo Vivi : > > As pointed out before we don't have a reliable way to read back ips > > status on BDW without the risk to disable it when reading. > > However now we are pretending that IPS on BDW is always on and getting > > people confused about it. > > > > So this patch allows people to know if ips was ever attempted to be enabled. > > Even if the current status is impossible to be ascertain. > > > > v2: (spotted by Paulo): > > * A version that at least compiles > > * with more clear messages > > * let Cheryview on the safe side until we aren't sure that checking ips > > state on ips won't disable it. > > > > Cc: Paulo Zanoni > > Signed-off-by: Rodrigo Vivi > > Reviewed-by: Paulo Zanoni Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch