From: Jesse Barnes Subject: Re: [PATCH 1/4] drm/i915: remove i915_delayedfreq_table debugfs entry Date: Wed, 9 Jul 2014 08:17:30 -0700 Message-ID: <20140709081730.60190e0d@jbarnes-desktop> References: <1404907846-330-1-git-send-email-mika.kuoppala@intel.com> <1404907846-330-2-git-send-email-mika.kuoppala@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) by gabe.freedesktop.org (Postfix) with ESMTP id 91BEC6E6D6 for ; Wed, 9 Jul 2014 08:16:35 -0700 (PDT) Received: by mail-pa0-f51.google.com with SMTP id hz1so9423268pad.10 for ; Wed, 09 Jul 2014 08:16:35 -0700 (PDT) In-Reply-To: <1404907846-330-2-git-send-email-mika.kuoppala@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mika Kuoppala Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 9 Jul 2014 15:10:43 +0300 Mika Kuoppala wrote: > CHV hard hangs on reading these registers. As these have not > been used since cantiga & ilk, remove the debugfs entry. > > References: https://bugs.freedesktop.org/show_bug.cgi?id=80893 > Suggested-by: Jesse Barnes > Signed-off-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/i915_debugfs.c | 27 --------------------------- > 1 file changed, 27 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c > index b3b56c4..6d471e1 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs.c > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -1158,32 +1158,6 @@ out: > return ret; > } > > -static int i915_delayfreq_table(struct seq_file *m, void *unused) > -{ > - struct drm_info_node *node = m->private; > - struct drm_device *dev = node->minor->dev; > - struct drm_i915_private *dev_priv = dev->dev_private; > - u32 delayfreq; > - int ret, i; > - > - ret = mutex_lock_interruptible(&dev->struct_mutex); > - if (ret) > - return ret; > - intel_runtime_pm_get(dev_priv); > - > - for (i = 0; i < 16; i++) { > - delayfreq = I915_READ(PXVFREQ_BASE + i * 4); > - seq_printf(m, "P%02dVIDFREQ: 0x%08x (VID: %d)\n", i, delayfreq, > - (delayfreq & PXVFREQ_PX_MASK) >> PXVFREQ_PX_SHIFT); > - } > - > - intel_runtime_pm_put(dev_priv); > - > - mutex_unlock(&dev->struct_mutex); > - > - return 0; > -} > - > static inline int MAP_TO_MV(int map) > { > return 1250 - (map * 25); > @@ -3952,7 +3926,6 @@ static const struct drm_info_list i915_debugfs_list[] = { > {"i915_gem_hws_vebox", i915_hws_info, 0, (void *)VECS}, > {"i915_rstdby_delays", i915_rstdby_delays, 0}, > {"i915_frequency_info", i915_frequency_info, 0}, > - {"i915_delayfreq_table", i915_delayfreq_table, 0}, > {"i915_inttoext_table", i915_inttoext_table, 0}, > {"i915_drpc_info", i915_drpc_info, 0}, > {"i915_emon_status", i915_emon_status, 0}, Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center