From: Daniel Vetter Subject: Re: [PATCH 1/7] drm/i915: Read guaranteed freq for valleyview Date: Fri, 11 Jul 2014 17:56:25 +0200 Message-ID: <20140711155625.GC17271@phenom.ffwll.local> References: <1404978387-28180-1-git-send-email-deepak.s@linux.intel.com> <1404978387-28180-2-git-send-email-deepak.s@linux.intel.com> <87lhs0j6s7.fsf@gaia.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f180.google.com (mail-we0-f180.google.com [74.125.82.180]) by gabe.freedesktop.org (Postfix) with ESMTP id E4EFA6E003 for ; Fri, 11 Jul 2014 08:56:17 -0700 (PDT) Received: by mail-we0-f180.google.com with SMTP id k48so379442wev.39 for ; Fri, 11 Jul 2014 08:56:16 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87lhs0j6s7.fsf@gaia.fi.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mika Kuoppala Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Jul 11, 2014 at 05:42:48PM +0300, Mika Kuoppala wrote: > deepak.s@linux.intel.com writes: > > > From: Deepak S > > > > Reading RP1 for valleyview to help us enable "pm_rps" i-g-t testcase > > execution. > > > > Signed-off-by: Deepak S > > Reviewed-by: Mika Kuoppala > > > --- > > drivers/gpu/drm/i915/intel_pm.c | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > > index d1af641..b8e7afc 100644 > > --- a/drivers/gpu/drm/i915/intel_pm.c > > +++ b/drivers/gpu/drm/i915/intel_pm.c > > @@ -3816,6 +3816,17 @@ int cherryview_rps_min_freq(struct drm_i915_private *dev_priv) > > return rpn; > > } > > > > +int valleyview_rps_guar_freq(struct drm_i915_private *dev_priv) Missing static here. Fixed and queued for -next, thanks for the patch. -Daniel > > +{ > > + u32 val, rp1; > > + > > + val = vlv_nc_read(dev_priv, IOSF_NC_FB_GFX_FREQ_FUSE); > > + > > + rp1 = (val & FB_GFX_FGUARANTEED_FREQ_FUSE_MASK) >> FB_GFX_FGUARANTEED_FREQ_FUSE_SHIFT; > > + > > + return rp1; > > +} > > + > > int valleyview_rps_max_freq(struct drm_i915_private *dev_priv) > > { > > u32 val, rp0; > > @@ -3958,6 +3969,11 @@ static void valleyview_init_gt_powersave(struct drm_device *dev) > > vlv_gpu_freq(dev_priv, dev_priv->rps.efficient_freq), > > dev_priv->rps.efficient_freq); > > > > + dev_priv->rps.rp1_freq = valleyview_rps_guar_freq(dev_priv); > > + DRM_DEBUG_DRIVER("RP1(Guar Freq) GPU freq: %d MHz (%u)\n", > > + vlv_gpu_freq(dev_priv, dev_priv->rps.rp1_freq), > > + dev_priv->rps.rp1_freq); > > + > > dev_priv->rps.min_freq = valleyview_rps_min_freq(dev_priv); > > DRM_DEBUG_DRIVER("min GPU freq: %d MHz (%u)\n", > > vlv_gpu_freq(dev_priv, dev_priv->rps.min_freq), > > -- > > 1.9.1 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch