From: Daniel Vetter Subject: Re: [PATCH] drm/i915: remove plane/cursor/pipe assertions from intel_crtc_disable Date: Thu, 17 Jul 2014 19:16:42 +0200 Message-ID: <20140717171642.GN15237@phenom.ffwll.local> References: <1405606599-3248-1-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by gabe.freedesktop.org (Postfix) with ESMTP id 514136E365 for ; Thu, 17 Jul 2014 10:16:34 -0700 (PDT) Received: by mail-wi0-f174.google.com with SMTP id d1so8094957wiv.13 for ; Thu, 17 Jul 2014 10:16:32 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1405606599-3248-1-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Thu, Jul 17, 2014 at 11:16:39AM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > Since we merged runtime PM support for DPMS, it is possible that these > assertions will be called when the power wells are disabled but a mode > is "set", resulting in "failed assertion" and "device suspended while > reading register" WARNs. > > To reproduce the bug: disable all screens using mode unset, do a > modeset on one screen, disable it using DPMS, then try to do a mode > unset on it again to see the WARNs. > > v2: The first version of this patch changed the assertions to also > check the power domains. Daniel suggested that it would be better to > just remove the assertions: "The modeset state checker > will already notice when we've failed to turn off the pipe. And we > check cursors and plane state in the enable sequence, too. Since we > use these asserts a lot to lock down the precise modeset sequence I > actually prefer if they're a bit dumb and don't check the power > wells." > > Testcase: igt/rpm_rpm/dpms-mode-unset-lpsp > Testcase: igt/rpm_rpm/dpms-mode-unset-non-lpsp > Signed-off-by: Paulo Zanoni Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch