From: Damien Lespiau Subject: Re: [PATCH 0/7] Future preparation patches Date: Fri, 18 Jul 2014 14:04:56 +0100 Message-ID: <20140718130456.GC32442@strange.amr.corp.intel.com> References: <1405661650-5771-1-git-send-email-sonika.jindal@intel.com> <20140718105616.GB31263@strange.amr.corp.intel.com> <53C903B6.3060608@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 71E436E0C3 for ; Fri, 18 Jul 2014 06:04:58 -0700 (PDT) Content-Disposition: inline In-Reply-To: <53C903B6.3060608@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Jindal, Sonika" Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Jul 18, 2014 at 04:53:34PM +0530, Jindal, Sonika wrote: > > > On 7/18/2014 4:26 PM, Damien Lespiau wrote: > >On Fri, Jul 18, 2014 at 11:04:03AM +0530, sonika.jindal@intel.com wrote: > >>From: Sonika Jindal > >> > >>This series prepares future platform enabling by changing HAS_PCH_SPLIT to more > >>appropriate check since the code accessed may not have anything to do with > >>having PCH or not. > > > >Hi Sonika, > > > >HAS_PCH_SPLIT() is true for Ironlake (gen 5) as it's paired with the > >Ibex Peak PCH. > > > >In various patches, the condition needs to be INTEL_INFO(dev)->gen < 5 > >then. > > > I am sorry, my understanding was that HAS_PCH_SPLIT is equivalent to > (gen > 5 && !(IS_VALLEYVIEW) ) > So, is it like, HAS_PCH_SPLIT is equivalent to (gen >=5 && !(IS_VALEYVIEW)) Yes, indeed! -- Damien