From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915: extract backlight minimum brightness from VBT Date: Wed, 23 Jul 2014 07:08:28 +0200 Message-ID: <20140723050828.GP15237@phenom.ffwll.local> References: <1403623660-1257-1-git-send-email-jani.nikula@intel.com> <20140722141918.2bfc8f6e@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44]) by gabe.freedesktop.org (Postfix) with ESMTP id A4F6E6E036 for ; Tue, 22 Jul 2014 22:08:19 -0700 (PDT) Received: by mail-wg0-f44.google.com with SMTP id m15so574668wgh.27 for ; Tue, 22 Jul 2014 22:08:18 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140722141918.2bfc8f6e@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jesse Barnes Cc: Jani Nikula , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Jul 22, 2014 at 02:19:18PM -0700, Jesse Barnes wrote: > On Tue, 24 Jun 2014 18:27:39 +0300 > Jani Nikula wrote: > > > Reviewed-by: Jesse Barnes > > Signed-off-by: Jani Nikula > > --- > > drivers/gpu/drm/i915/i915_drv.h | 1 + > > drivers/gpu/drm/i915/intel_bios.c | 3 ++- > > 2 files changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > > index 8cea59649ef2..81e8d17063d5 100644 > > --- a/drivers/gpu/drm/i915/i915_drv.h > > +++ b/drivers/gpu/drm/i915/i915_drv.h > > @@ -1230,6 +1230,7 @@ struct intel_vbt_data { > > u16 pwm_freq_hz; > > bool present; > > bool active_low_pwm; > > + u8 min_brightness; /* min_brightness/255 of max */ > > } backlight; > > > > /* MIPI DSI */ > > diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c > > index 827498e081df..608ed302f24d 100644 > > --- a/drivers/gpu/drm/i915/intel_bios.c > > +++ b/drivers/gpu/drm/i915/intel_bios.c > > @@ -336,11 +336,12 @@ parse_lfp_backlight(struct drm_i915_private *dev_priv, struct bdb_header *bdb) > > > > dev_priv->vbt.backlight.pwm_freq_hz = entry->pwm_freq_hz; > > dev_priv->vbt.backlight.active_low_pwm = entry->active_low_pwm; > > + dev_priv->vbt.backlight.min_brightness = entry->min_brightness; > > DRM_DEBUG_KMS("VBT backlight PWM modulation frequency %u Hz, " > > "active %s, min brightness %u, level %u\n", > > dev_priv->vbt.backlight.pwm_freq_hz, > > dev_priv->vbt.backlight.active_low_pwm ? "low" : "high", > > - entry->min_brightness, > > + dev_priv->vbt.backlight.min_brightness, > > backlight_data->level[panel_type]); > > } > > > > Reviewed-by: Jesse Barnes Both merged to dinq, thanks. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch