From: David Sterba Subject: Re: [PATCH 2/4 v3] fiemap: add EXTENT_DATA_COMPRESSED flag Date: Thu, 24 Jul 2014 21:22:45 +0200 Message-ID: <20140724192245.GG1553@suse.cz> References: <4f8d5dc5b51a43efaf16c39398c23a6276e40a30.1386778303.git.dsterba@suse.cz> <20131212232443.GL31386@dastard> <9520AB36-B728-423A-8EA1-FDD22B79AE90@dilger.ca> Reply-To: dsterba-AlSwsSmVLrQ@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel , linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, xfs-VZNHf3L845pBDgjK7y7TUQ@public.gmane.org, Btrfs Developer List , Ext4 Developers List , ocfs2-devel-N0ozoZBvEnrZJqsBc5GL+g@public.gmane.org To: Andreas Dilger Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-nilfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-ext4.vger.kernel.org On Thu, Jul 17, 2014 at 12:07:57AM -0600, Andreas Dilger wrote: > any progress on this patch series? I'm sorry I got distracted at the end of year and did not finish the series. > I never saw an updated version of this patch series after the last round of > reviews, but it would be great to move it forward. I have filefrag patches > in my e2fsprogs tree waiting for an updated version of your patch. > > I recall the main changes were: > - add FIEMAP_EXTENT_PHYS_LENGTH flag to indicate if fe_phys_length was valid fe_phys_length will be always valid, so other the flags are set only if it's not equal to the logical length. > - rename fe_length to fe_logi_length and #define fe_length fe_logi_length > - always fill in fe_phys_length (= fe_logi_length for uncompressed files) > and set FIEMAP_EXTENT_PHYS_LENGTH whether the extent is compressed or not This is my understanding and contradicts the first point. > - add WARN_ONCE() in fiemap_fill_next_extent() as described below > > I don't know if there was any clear statement about whether there should be > separate FIEMAP_EXTENT_PHYS_LENGTH and FIEMAP_EXTENT_DATA_COMPRESSED flags, > or if the latter should be implicit? Probably makes sense to have separate > flags. It should be fine to use: > > #define FIEMAP_EXTENT_PHYS_LENGTH 0x00000010 > > since this flag was never used. I've kept only FIEMAP_EXTENT_DATA_COMPRESSED, I don't see a need for FIEMAP_EXTENT_PHYS_LENGTH and this would be yet another flag because the FIEMAP_EXTENT_DATA_ENCODED is also implied. I'll send V4, we can discuss the PHYS_LENGTH flag then. -- To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html