From: Damien Lespiau Subject: Re: [PATCH v2] drm/i915: Rename defines for selection of ddi buffer translation slot Date: Fri, 8 Aug 2014 13:36:17 +0100 Message-ID: <20140808123617.GB2751@strange.ger.corp.intel.com> References: <1407500245-11436-1-git-send-email-sonika.jindal@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 3FC336E2CE for ; Fri, 8 Aug 2014 05:36:48 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1407500245-11436-1-git-send-email-sonika.jindal@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: sonika.jindal@intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Aug 08, 2014 at 05:47:25PM +0530, sonika.jindal@intel.com wrote: > /* Start the training iterating through available voltages and emphasis, > * testing each value twice. */ > - for (i = 0; i < ARRAY_SIZE(hsw_ddi_buf_ctl_values) * 2; i++) { > + for (i = 0; i < ARRAY_SIZE(hsw_ddi_translations_fdi); i++) { This is correct but obsfucated. You're actually doing ARRAY_SIZE(hsw_ddi_translations_fdi) / 2 * 2 and we might as well give the ARRAY_SIZE(hsw_ddi_translations_fdi) / 2 a proper name like I suggested. With that fixed, you can add my: Reviewed-by: Damien Lespiau -- Damien