From: Daniel Vetter Subject: Re: [PATCH] drm/i915: remove pixel doubled HDMI modes from valid modes list Date: Tue, 12 Aug 2014 08:59:44 +0200 Message-ID: <20140812065944.GJ10500@phenom.ffwll.local> References: <1407796382-6168-1-git-send-email-clinton.a.taylor@intel.com> <20140812063924.GK6666@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by gabe.freedesktop.org (Postfix) with ESMTP id 2AA886E37E for ; Mon, 11 Aug 2014 23:59:33 -0700 (PDT) Received: by mail-wi0-f182.google.com with SMTP id d1so5285882wiv.3 for ; Mon, 11 Aug 2014 23:59:32 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140812063924.GK6666@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , clinton.a.taylor@intel.com, Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Aug 12, 2014 at 07:39:24AM +0100, Chris Wilson wrote: > On Mon, Aug 11, 2014 at 03:33:02PM -0700, clinton.a.taylor@intel.com wrote: > > From: Clint Taylor > > > > Intel HDMI does not correctly configure pixel replicated HDMI modes > > 480i and 576i. Remove support for these modes until DRM has been > > changed to correctly identify SD interlaced modes by reporting there > > true horizontal resolution 720 instead of the pre-pixel doubled 1440. > > > > Signed-off-by: Clint Taylor > > --- > > drivers/gpu/drm/i915/intel_hdmi.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c > > index 5f47d35..ab32523 100644 > > --- a/drivers/gpu/drm/i915/intel_hdmi.c > > +++ b/drivers/gpu/drm/i915/intel_hdmi.c > > @@ -873,6 +873,9 @@ intel_hdmi_mode_valid(struct drm_connector *connector, > > if (mode->flags & DRM_MODE_FLAG_DBLSCAN) > > return MODE_NO_DBLESCAN; > > > > If it is just a workaround for a drm bug. You need a big comment > explaining why you w/a rather than pressing for the bug fix. Well there's a very small chance I'll take this anyway - if the drm core is broken we need to take out the mode from the drm core, not here. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch