From: Konrad Rzeszutek Wilk Subject: Re: [PATCH v7 1/9] xen: vnuma topology and subop hypercalls Date: Thu, 21 Aug 2014 12:25:31 -0400 Message-ID: <20140821162531.GA9114@andromeda.dapyr.net> References: <1408081383-25313-1-git-send-email-ufimtseva@gmail.com> <1408081383-25313-2-git-send-email-ufimtseva@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1408081383-25313-2-git-send-email-ufimtseva@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Elena Ufimtseva Cc: keir@xen.org, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, george.dunlap@eu.citrix.com, msw@linux.com, dario.faggioli@citrix.com, lccycc123@gmail.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, JBeulich@suse.com List-Id: xen-devel@lists.xenproject.org On Fri, Aug 15, 2014 at 01:43:03AM -0400, Elena Ufimtseva wrote: > Define interface, structures and hypercalls for toolstack to > build vnuma topology and for guests that wish to retrieve it. > Two subop hypercalls introduced by patch: > XEN_DOMCTL_setvnumainfo to define vNUMA domain topology per domain > and XENMEM_get_vnumainfo to retrieve that topology by guest. > > Signed-off-by: Elena Ufimtseva One single change (comment) and with that it is Reviewed-by: Konrad Rzeszutek Wilk .. snip.. > +static int vnuma_alloc(struct vnuma_info **vnuma, > + unsigned int nr_vnodes, > + unsigned int nr_vcpus) > +{ > + if ( vnuma && *vnuma ) > + return -EINVAL; > + > + if ( nr_vnodes > XEN_MAX_VNODES ) > + return -EINVAL; > + > + /* > + * If XEN_MAX_VNODES increases, these allocations > + * should be split into PAGE_SIZE allocations > + * due to XCA-77. s/XCA/XSA/