From: Damien Lespiau Subject: Re: [PATCH 2/3] drm/i915: rename gen8_init_clock_gating to broadwell_init_clock_gating Date: Thu, 21 Aug 2014 22:45:06 +0100 Message-ID: <20140821214506.GB29975@strange.ger.corp.intel.com> References: <1408651778-2636-1-git-send-email-przanoni@gmail.com> <1408651778-2636-2-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 9F8546E29C for ; Thu, 21 Aug 2014 14:45:21 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1408651778-2636-2-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Thu, Aug 21, 2014 at 05:09:37PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > Because CHV uses cherryview_init_clock_gating instead of > gen8_init_clock_gating. > > Signed-off-by: Paulo Zanoni Reviewed-by: Damien Lespiau -- Damien > --- > drivers/gpu/drm/i915/intel_pm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > I really wish we were using the three-letter-acronyms instead of the full names > on the functions. If I send another patch renaming everything, will anybody > complain? > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > index b3e948f..35495fc 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -5502,7 +5502,7 @@ static void lpt_suspend_hw(struct drm_device *dev) > } > } > > -static void gen8_init_clock_gating(struct drm_device *dev) > +static void broadwell_init_clock_gating(struct drm_device *dev) > { > struct drm_i915_private *dev_priv = dev->dev_private; > enum pipe pipe; > @@ -7251,7 +7251,7 @@ void intel_init_pm(struct drm_device *dev) > else if (IS_HASWELL(dev)) > dev_priv->display.init_clock_gating = haswell_init_clock_gating; > else if (INTEL_INFO(dev)->gen == 8) > - dev_priv->display.init_clock_gating = gen8_init_clock_gating; > + dev_priv->display.init_clock_gating = broadwell_init_clock_gating; > } else if (IS_CHERRYVIEW(dev)) { > dev_priv->display.update_wm = cherryview_update_wm; > dev_priv->display.update_sprite_wm = valleyview_update_sprite_wm; > -- > 2.0.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx