From: Daniel Vetter Subject: Re: [PATCH] drm/i915/bdw: Initialize workarounds in render ring init fn. Date: Mon, 25 Aug 2014 23:39:19 +0200 Message-ID: <20140825213919.GU15520@phenom.ffwll.local> References: <1408035060-26456-1-git-send-email-arun.siluvery@linux.intel.com> <53EE9722.5020606@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 273A189F6F for ; Mon, 25 Aug 2014 14:38:57 -0700 (PDT) Received: by mail-wg0-f49.google.com with SMTP id k14so13674516wgh.20 for ; Mon, 25 Aug 2014 14:38:56 -0700 (PDT) Content-Disposition: inline In-Reply-To: <53EE9722.5020606@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Michael H. Nguyen" Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Aug 15, 2014 at 04:26:26PM -0700, Michael H. Nguyen wrote: > Also, should this be defined in a userspace accessible header? I see this > defined again locally in the IGT test. It's a debugfs interface, i.e. no real ABI guarantees. And so better not to expose this in any of the uapi header files. We've done pretty much the same duplication for all other debugfs files used in igt tests. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch