From: Daniel Vetter Subject: Re: [PATCH] drm/i915: don't check for i830 in vlv specific code Date: Tue, 26 Aug 2014 08:48:46 +0200 Message-ID: <20140826064846.GV15520@phenom.ffwll.local> References: <1408709195-21974-1-git-send-email-jani.nikula@intel.com> <20140822124430.GV4193@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) by gabe.freedesktop.org (Postfix) with ESMTP id 590E46E470 for ; Mon, 25 Aug 2014 23:48:24 -0700 (PDT) Received: by mail-wg0-f52.google.com with SMTP id a1so13965852wgh.23 for ; Mon, 25 Aug 2014 23:48:23 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140822124430.GV4193@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Jani Nikula , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Aug 22, 2014 at 03:44:30PM +0300, Ville Syrj=E4l=E4 wrote: > On Fri, Aug 22, 2014 at 03:06:35PM +0300, Jani Nikula wrote: > > Signed-off-by: Jani Nikula > > --- > > drivers/gpu/drm/i915/intel_display.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > = > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i91= 5/intel_display.c > > index 51b4cd29f932..83eabd758ed9 100644 > > --- a/drivers/gpu/drm/i915/intel_display.c > > +++ b/drivers/gpu/drm/i915/intel_display.c > > @@ -1546,7 +1546,7 @@ static void vlv_enable_pll(struct intel_crtc *crt= c) > > BUG_ON(!IS_VALLEYVIEW(dev_priv->dev)); > > = > > /* PLL is protected by panel, make sure we can write it */ > > - if (IS_MOBILE(dev_priv->dev) && !IS_I830(dev_priv->dev)) > > + if (IS_MOBILE(dev_priv->dev)) > > assert_panel_unlocked(dev_priv, crtc->pipe); > = > My gut feeling is that the IS_MOBILE check could also be dropped. Not > quite sure though since VLV_D is not mentioned anywhere in the docs > AFAICS. I think in the old gens we've pretty much just used IS_MOBILE as HAS_LVDS. vlv/chv having edp panels instead makes that a bit more complicated, but generally I think a new IS_MOBILE check is bogus. > Anyway dropping the 830 check definitely makes sense so: > Reviewed-by: Ville Syrj=E4l=E4 Queued for -next, thanks for the patch. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch