From: Daniel Vetter Subject: Re: [PATCH] drm/i915/bdw: Add BDW support in the i915 debugfs entry Date: Tue, 26 Aug 2014 15:30:26 +0200 Message-ID: <20140826133026.GW15520@phenom.ffwll.local> References: <1408561471-15812-1-git-send-email-vedang.patel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by gabe.freedesktop.org (Postfix) with ESMTP id 8D1796E50A for ; Tue, 26 Aug 2014 06:30:03 -0700 (PDT) Received: by mail-wi0-f179.google.com with SMTP id f8so4154021wiw.12 for ; Tue, 26 Aug 2014 06:30:02 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1408561471-15812-1-git-send-email-vedang.patel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: vedang.patel@intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Aug 20, 2014 at 12:04:31PM -0700, vedang.patel@intel.com wrote: > From: Vedang Patel > > The patch introduces fixes for the debugfs attributes emitted by > the i915 driver for GEN8. Currently, it is not emitting the correct > attributes which include the status of RC6 states. > > Change-Id: Ib2068a0cac9a5wq3f228e547fa1a097ad369d242df > Signed-off-by: Vedang Patel > --- > drivers/gpu/drm/i915/i915_debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c > index 850fa59..2296a22 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs.c > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -1329,7 +1329,7 @@ static int i915_drpc_info(struct seq_file *m, void *unused) > > if (IS_VALLEYVIEW(dev)) > return vlv_drpc_info(m); > - else if (IS_GEN6(dev) || IS_GEN7(dev)) > + else if (IS_GEN6(dev) || IS_GEN7(dev) || IS_GEN8(dev)) I think an INTEL_INFO(dev)->gen >= 6 check here looks better and is more future proof. Can you please update the patch accordingly? Thanks, Daniel > return gen6_drpc_info(m); > else > return ironlake_drpc_info(m); > -- > 1.7.9.5 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch