From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915: reorganize the unclaimed register detection code Date: Tue, 26 Aug 2014 15:34:07 +0200 Message-ID: <20140826133407.GX15520@phenom.ffwll.local> References: <20140716135707.GY15237@phenom.ffwll.local> <1405543770-3212-1-git-send-email-przanoni@gmail.com> <20140826102225.GD5458@nuc-i3427.alporthouse.com> <20140826124213.GI5458@nuc-i3427.alporthouse.com> <20140826131858.GJ5458@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f47.google.com (mail-wg0-f47.google.com [74.125.82.47]) by gabe.freedesktop.org (Postfix) with ESMTP id 0E2C96E50C for ; Tue, 26 Aug 2014 06:33:44 -0700 (PDT) Received: by mail-wg0-f47.google.com with SMTP id b13so14276971wgh.6 for ; Tue, 26 Aug 2014 06:33:44 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: Intel Graphics Development , Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Tue, Aug 26, 2014 at 10:29:23AM -0300, Paulo Zanoni wrote: > 2014-08-26 10:18 GMT-03:00 Chris Wilson : > > On Tue, Aug 26, 2014 at 10:04:22AM -0300, Paulo Zanoni wrote: > >> Of course, we can also implement the one-shot thing on top of the > >> above, but it won't really help us reducing the amount of reads on the > >> "happy case" where we never got the error before. > > > > Actually I am tempted to dynamically patch the mmio vfuncs to avoid even > > the forcewake spinlock when we already hold it. So there won't be any > > such logic except when enabled by the user. > > Should I expect a patch from you, or should I go and write the patch > based on what we already discussed? Imo this is crazy - we have no control over what the compiler does and when exactly it loads vtable entries, so patching them at runtime would be an interesting excercise at best. Adding a special version of I915_READ/WRITE for the irq hotpath makes sense, but only if we can actually show a benefit in benchmarks. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch