From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915: reorganize the unclaimed register detection code Date: Tue, 26 Aug 2014 16:08:36 +0200 Message-ID: <20140826140835.GB15520@phenom.ffwll.local> References: <20140716135707.GY15237@phenom.ffwll.local> <1405543770-3212-1-git-send-email-przanoni@gmail.com> <20140826102225.GD5458@nuc-i3427.alporthouse.com> <20140826124213.GI5458@nuc-i3427.alporthouse.com> <20140826131858.GJ5458@nuc-i3427.alporthouse.com> <20140826133407.GX15520@phenom.ffwll.local> <20140826134625.GK5458@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by gabe.freedesktop.org (Postfix) with ESMTP id 740346E07C for ; Tue, 26 Aug 2014 07:08:13 -0700 (PDT) Received: by mail-wi0-f178.google.com with SMTP id hi2so4218553wib.5 for ; Tue, 26 Aug 2014 07:08:12 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140826134625.GK5458@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Daniel Vetter , Paulo Zanoni , Intel Graphics Development , Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Tue, Aug 26, 2014 at 02:46:25PM +0100, Chris Wilson wrote: > On Tue, Aug 26, 2014 at 03:34:07PM +0200, Daniel Vetter wrote: > > On Tue, Aug 26, 2014 at 10:29:23AM -0300, Paulo Zanoni wrote: > > > 2014-08-26 10:18 GMT-03:00 Chris Wilson : > > > > On Tue, Aug 26, 2014 at 10:04:22AM -0300, Paulo Zanoni wrote: > > > >> Of course, we can also implement the one-shot thing on top of the > > > >> above, but it won't really help us reducing the amount of reads on the > > > >> "happy case" where we never got the error before. > > > > > > > > Actually I am tempted to dynamically patch the mmio vfuncs to avoid even > > > > the forcewake spinlock when we already hold it. So there won't be any > > > > such logic except when enabled by the user. > > > > > > Should I expect a patch from you, or should I go and write the patch > > > based on what we already discussed? > > > > Imo this is crazy - we have no control over what the compiler does and > > when exactly it loads vtable entries, so patching them at runtime would be > > an interesting excercise at best. > > Wtf? I've assumed you'd runtime patch the vtables or something like that. And I didn't see any other less crazy way to ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch