From: Damien Lespiau Subject: Re: [PATCH] drm/i915/ddi: use struct for ddi buf translation tables Date: Wed, 27 Aug 2014 14:47:05 +0100 Message-ID: <20140827134704.GE2292@strange.ger.corp.intel.com> References: <20140827112628.GB2292@strange.ger.corp.intel.com> <1409146050-25561-1-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 7983A6E396 for ; Wed, 27 Aug 2014 06:47:36 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1409146050-25561-1-git-send-email-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Aug 27, 2014 at 04:27:30PM +0300, Jani Nikula wrote: > /* Entry 9 is for HDMI: */ > for (i = 0; i < 2; i++) { > - I915_WRITE(reg, ddi_translations_hdmi[hdmi_level * 2 + i]); > + I915_WRITE(reg, ddi_translations_hdmi[hdmi_level + i].trans1); > + reg += 4; > + I915_WRITE(reg, ddi_translations_hdmi[hdmi_level + i].trans2); > reg += 4; > } It seems we're writing a bit too many times there now (we don't need the the for() loop anymore). -- Damien