From: Daniel Vetter Subject: Re: [PATCH] drm/i915/ddi: use struct for ddi buf translation tables Date: Wed, 27 Aug 2014 15:55:17 +0200 Message-ID: <20140827135517.GU15520@phenom.ffwll.local> References: <20140827112628.GB2292@strange.ger.corp.intel.com> <1409146050-25561-1-git-send-email-jani.nikula@intel.com> <20140827134704.GE2292@strange.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50]) by gabe.freedesktop.org (Postfix) with ESMTP id 341326E3A6 for ; Wed, 27 Aug 2014 06:54:58 -0700 (PDT) Received: by mail-wg0-f50.google.com with SMTP id n12so249313wgh.33 for ; Wed, 27 Aug 2014 06:54:57 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140827134704.GE2292@strange.ger.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Damien Lespiau Cc: Jani Nikula , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Aug 27, 2014 at 02:47:05PM +0100, Damien Lespiau wrote: > On Wed, Aug 27, 2014 at 04:27:30PM +0300, Jani Nikula wrote: > > /* Entry 9 is for HDMI: */ > > for (i = 0; i < 2; i++) { > > - I915_WRITE(reg, ddi_translations_hdmi[hdmi_level * 2 + i]); > > + I915_WRITE(reg, ddi_translations_hdmi[hdmi_level + i].trans1); > > + reg += 4; > > + I915_WRITE(reg, ddi_translations_hdmi[hdmi_level + i].trans2); > > reg += 4; > > } > > It seems we're writing a bit too many times there now (we don't need the > the for() loop anymore). It totally never happend ;-) Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch