From: Daniel Vetter Subject: Re: [PATCH 2/2] drm/i915: s, fb->bits_per_pixel/8, pixel_size, in primary plane code Date: Wed, 27 Aug 2014 17:54:42 +0200 Message-ID: <20140827155442.GX15520@phenom.ffwll.local> References: <1409147482-10376-1-git-send-email-ville.syrjala@linux.intel.com> <1409147482-10376-2-git-send-email-ville.syrjala@linux.intel.com> <20140827142113.GH13629@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-we0-f172.google.com (mail-we0-f172.google.com [74.125.82.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 7ED3E6E4B4 for ; Wed, 27 Aug 2014 08:54:24 -0700 (PDT) Received: by mail-we0-f172.google.com with SMTP id x48so423342wes.31 for ; Wed, 27 Aug 2014 08:54:21 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140827142113.GH13629@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Aug 27, 2014 at 03:21:13PM +0100, Chris Wilson wrote: > On Wed, Aug 27, 2014 at 04:51:22PM +0300, ville.syrjala@linux.intel.com w= rote: > > From: Ville Syrj=E4l=E4 > > = > > Use the pixel_size we got from drm_format_plane_cpp() instead of > > fb->bits_per_pixel/8 when computing the primary plane page/linear > > offsets. Avoids a few divs and makes the code more future proof > > against funky pixel formats where bits_per_pixel isn't well defined. > > This is what we already did in the sprite code. > = > A little bit of software archeology revealed > = > commit ca320ac456099c29290568353d924157e626ede9 > Author: Chris Wilson > Date: Wed Dec 19 12:14:22 2012 +0000 > = > drm/i915: Use pixel size for computing linear offsets into a sprite > = > I misremembered that as an oops in the primary plane when using > pixel_size. That concern addressed, I've added this for additional context as a note to the commit message. > Reviewed-by: Chris Wilson Both patches merged, thanks. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch