From: Damien Lespiau Subject: Re: [PATCH] igt/gem_workarounds: igt to test workaround registers Date: Sat, 30 Aug 2014 16:22:04 +0100 Message-ID: <20140830152203.GB30509@strange.ger.corp.intel.com> References: <1409061028-5087-1-git-send-email-arun.siluvery@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id A9C5E6E120 for ; Sat, 30 Aug 2014 08:22:06 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1409061028-5087-1-git-send-email-arun.siluvery@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Arun Siluvery Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Aug 26, 2014 at 02:50:28PM +0100, Arun Siluvery wrote: > + igt_subtest("check-workaround-data-after-suspend-resume") { > + if (IS_BROADWELL(devid)) > + check_workarounds(SUSPEND_RESUME, num_wa_regs); > + else > + igt_skip_on("No Workaround table available!!\n"); > + } This kind of check needs updating for each platform. That generates a lot of "stupid" work. And indeed, it's already out of date (CHV). We should be able to use some information from the debugfs file directly to do the right thing. With your current format for the debugfs file, I don't think we need a platform test at all. platforms that don't have a list will just expose: "Workarounds applied: 0\n" and we can happily pass the test. -- Damien