From: Masahiro Yamada Date: Fri, 05 Sep 2014 12:01:51 +0900 Subject: [U-Boot] [PATCH] nand/denali: Adding Denali NAND driver support In-Reply-To: <1409710552.24184.90.camel@snotra.buserror.net> References: <20140830114549.GV19374@bill-the-cat> <1409710552.24184.90.camel@snotra.buserror.net> Message-ID: <20140905120151.4FA2.AA925319@jp.panasonic.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Chin, Are you planning to send v10 with the fixes suggested by Scott? Best Regards Masahiro Yamada On Tue, 2 Sep 2014 21:15:52 -0500 Scott Wood wrote: > On Sat, 2014-08-30 at 07:45 -0400, Tom Rini wrote: > > On Thu, Aug 28, 2014 at 11:13:40AM +0900, Masahiro Yamada wrote: > > > Hi Scott, > > > > > > > > > On Tue, 19 Aug 2014 04:47:40 -0500 > > > Chin Liang See wrote: > > > > > > > To add the Denali NAND driver support into U-Boot. > > > > This driver is leveraged from Linux. > > > > > > > > Signed-off-by: Chin Liang See > > > > Cc: Scott Wood > > > > Cc: Masahiro Yamada > > > > --- > > > > Changes for v9 > > > > - Updated the commit messageb > > > > - Removed macro kern_xx > > > > - Removed debug macro > > > > - Changed CONFIG_NAND_DENALI_64BIT to CONFIG_SYS_NAND_DENALI_64BIT > > > > > > > > > Any comments? > > > > > > If nothing, please apply this patch. > > > > I don't see anything obviously wrong here, but since Scott has reviewed > > previous versions I want to give him a little more time to ack. I'm OK > > pulling this into master with Scott's ack or lets say Wednesday next > > week and we'll ask Chin Liang to address any late feedback. Thanks all! > > I still don't see a reference to the SHA of the corresponding Linux > driver. > > #define MODE5_WORKAROUND 0 still exists even though it's never used. > > I still see (void *) casts in memcpy -- v8 comments said "removed" but > not all instances were removed. > > It still introduces CONFIG_SYS_NAND_DENALI_64BIT without documenting it. > > -scott >