From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Enable full PPGTT on gen7 Date: Mon, 8 Sep 2014 09:43:24 +0200 Message-ID: <20140908074324.GO15520@phenom.ffwll.local> References: <1409922796-453-1-git-send-email-michel.thierry@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by gabe.freedesktop.org (Postfix) with ESMTP id EE05C6E221 for ; Mon, 8 Sep 2014 00:42:58 -0700 (PDT) Received: by mail-wg0-f49.google.com with SMTP id m15so1024258wgh.8 for ; Mon, 08 Sep 2014 00:42:58 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1409922796-453-1-git-send-email-michel.thierry@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Michel Thierry Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Sep 05, 2014 at 02:13:16PM +0100, Michel Thierry wrote: > Use full PPGTT as the default option in gen7. > Note that aliasing PPGTT is the default option for gen8 (see HAS_PPGTT). > > This may well come back to bite me later. > > Signed-off-by: Michel Thierry Queued for -next, thanks for the patch. And I've added a note that gen8 is blocked on execlists and other troubles for now. -Daniel > --- > drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c > index fc46647..30ab56a 100644 > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c > @@ -59,7 +59,7 @@ static int sanitize_enable_ppgtt(struct drm_device *dev, int enable_ppgtt) > return 0; > } > > - return HAS_ALIASING_PPGTT(dev) ? 1 : 0; > + return HAS_PPGTT(dev) ? 2 : HAS_ALIASING_PPGTT(dev) ? 1 : 0; > } > > > -- > 2.0.3 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch