From: tj@kernel.org (Tejun Heo) Date: Mon, 15 Sep 2014 16:44:52 +0900 Subject: [PATCH] ahci_xgene: Fix the error print invalid resource for APM X-Gene SoC AHCI SATA Host Controller driver. In-Reply-To: References: <1410508448-25111-1-git-send-email-stripathi@apm.com> <1410508448-25111-2-git-send-email-stripathi@apm.com> <20140912175014.GA6298@mtj.dyndns.org> <20140914093911.GB9028@mtj.dyndns.org> Message-ID: <20140915074452.GC11267@mtj.dyndns.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Sep 15, 2014 at 01:10:01PM +0530, Suman Tripathi wrote: > [suman] : So the posted version is acceptable ? Any others comments on this > patch ? I'm suggesting setting ctx->cs_mux to NULL on failure. IOW, if (res) { ctx->csr_mux = devm_ioremap_resources(); if (IS_ERR(ctx->csr_mux)) { print warning or something; ctx->csr_mux = NULL; } } Thanks. -- tejun