Received: from eggs.gnu.org ([2001:4830:134:3::10]:47973) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTv6i-0003co-14 for qemu-devel@nongnu.org; Tue, 16 Sep 2014 11:56:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTv6b-0007i5-CK for qemu-devel@nongnu.org; Tue, 16 Sep 2014 11:55:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3564) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTv6a-0007hR-V3 for qemu-devel@nongnu.org; Tue, 16 Sep 2014 11:55:49 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8GFtjjq002397 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 16 Sep 2014 11:55:45 -0400 Date: Tue, 16 Sep 2014 12:55:26 -0300 From: Marcelo Tosatti Message-ID: <20140916155526.GB29476@amt.cnet> References: <20140916151437.GA27819@amt.cnet> <54185A58.2010105@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54185A58.2010105@redhat.com> Subject: Re: [Qemu-devel] [PATCH] kvmclock: clarify usage of cpu_clean_all_dirty List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel On Tue, Sep 16, 2014 at 05:42:16PM +0200, Paolo Bonzini wrote: > Il 16/09/2014 17:14, Marcelo Tosatti ha scritto: > > + /* > > + * Make sure that CPU state is synchronized from KVM > > + * once every VM state change callback has finished. > > Which other callback could affect the in-kernel state, Marcin mentioned that APIC state was the culprit. Perhaps bdrv_drain_all(); ret = bdrv_flush_all(); Can change the interrupt state ? Then that should read "once VM stop has finished". > call cpu_clean_all_dirty instead? > > Paolo > > > + */ > > cpu_clean_all_dirty();