From: Tom Rini Date: Thu, 18 Sep 2014 17:59:32 -0400 Subject: [U-Boot] [PATCH 3/3] compiler.h: remove duplicated uninitialized_var In-Reply-To: <541AA860.8080101@myspectrum.nl> References: <1410978828-20292-1-git-send-email-jeroen@myspectrum.nl> <1410978828-20292-4-git-send-email-jeroen@myspectrum.nl> <20140918111434.70CC.AA925319@jp.panasonic.com> <541AA860.8080101@myspectrum.nl> Message-ID: <20140918215932.GY25506@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Sep 18, 2014 at 11:39:44AM +0200, Jeroen Hofstee wrote: > Hello Masahiro, > > On 18-09-14 04:14, Masahiro Yamada wrote: > >>Since clang has a different definition for uninitialized_var > >>it will complain that it is redefined in include/compiler.h. > >>Since these are already defined in linux/compiler.h just remove > >>this instance. > >> > >>Cc: Masahiro Yamada > >>Cc: Tom Rini > >>Signed-off-by: Jeroen Hofstee > > > > > >I don't mind this patch but it has made me realize > >another problem. > > > > > >We have both include/compiler.h and include/linux/compiler.h. > >Some sources use tha former and others use the latter. > > > >I don't know how to use the right one in the right place. > > no me neither, although it seems arch / drivers tend to use > linux/compiler.h more while tools include compiler.h more. My first guess is that we can't as easily throw into tools and thus need that around just for tools. Perhaps we should note as much in and fix regular code to use ? -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: