Received: from eggs.gnu.org ([2001:4830:134:3::10]:32960) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWmD8-00018Y-AL for qemu-devel@nongnu.org; Wed, 24 Sep 2014 09:02:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWmCy-0000pV-Tr for qemu-devel@nongnu.org; Wed, 24 Sep 2014 09:02:22 -0400 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:49191) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWmCy-0000oJ-KI for qemu-devel@nongnu.org; Wed, 24 Sep 2014 09:02:12 -0400 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 24 Sep 2014 14:02:04 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id DF2111B0804B for ; Wed, 24 Sep 2014 14:03:12 +0100 (BST) Received: from d06av09.portsmouth.uk.ibm.com (d06av09.portsmouth.uk.ibm.com [9.149.37.250]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s8OD23PU25034940 for ; Wed, 24 Sep 2014 13:02:03 GMT Received: from d06av09.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s8OD22cU029879 for ; Wed, 24 Sep 2014 07:02:03 -0600 Date: Wed, 24 Sep 2014 15:01:44 +0200 From: Cornelia Huck Message-ID: <20140924150144.7bdb7fb0.cornelia.huck@de.ibm.com> In-Reply-To: <1411559299-19042-1-git-send-email-imammedo@redhat.com> References: <1411559299-19042-1-git-send-email-imammedo@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/30] complete conversion to hotplug-handler API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: dmitry@daynix.com, mst@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, borntraeger@de.ibm.com, kraxel@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com, rth@twiddle.net On Wed, 24 Sep 2014 11:47:49 +0000 Igor Mammedov wrote: > Series unifies different hotplug mechanisms to a recent > hotplug-handler API and does shallow conversion of > devices that still use legacy qdev hotplug to it dropping > not used after that legacy hotplug path [29/30]. > It also relaces SCSI's own way to do hotplug/unplug with > hotplug-handler callbacks leaving it the only method > perform hotplug tasks. > And the last patch [30/30] allows to unplug of BUS-less > devices using hotplug-handler API. > > Converted devices are covered with new hotplug > unit-tests, except of: > s390x-*: I have no idea how or means to test it, but code > is close to virtio, so it's converted using > virtio template > pvscsi: is broken, so no means to test it > > Git tree for testing: > https://github.com/imammedo/qemu/commits/hp_ctrl_conversion_v1 Gave it a quick test with the s390-ccw-virtio machine. device_add virtio-balloon-ccw,id=xxx,devno=fe.2.1111 works (device added in qemu and crws injected to guest). However, device_del xxx removes the device in qemu but no crws are injected to the guest. That seems to indicate that virtio_ccw_busdev_unplug() isn't called? Indeed, the callback isn't invoked for hotunplug.