Received: from eggs.gnu.org ([2001:4830:134:3::10]:49244) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWnDW-0003GE-1a for qemu-devel@nongnu.org; Wed, 24 Sep 2014 10:06:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWnDO-0001J9-Ai for qemu-devel@nongnu.org; Wed, 24 Sep 2014 10:06:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55490) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWnDO-0001Ic-3Q for qemu-devel@nongnu.org; Wed, 24 Sep 2014 10:06:42 -0400 Date: Wed, 24 Sep 2014 16:06:26 +0200 From: Igor Mammedov Message-ID: <20140924160626.687a7f0b@nial.usersys.redhat.com> In-Reply-To: <1411561825.30748.1.camel@nilsson.home.kraxel.org> References: <1411559299-19042-1-git-send-email-imammedo@redhat.com> <1411559299-19042-7-git-send-email-imammedo@redhat.com> <1411561825.30748.1.camel@nilsson.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 06/30] test: usb: add port test to uhci unit test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: dmitry@daynix.com, mst@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, cornelia.huck@de.ibm.com, amit.shah@redhat.com, pbonzini@redhat.com, borntraeger@de.ibm.com, rth@twiddle.net On Wed, 24 Sep 2014 14:30:25 +0200 Gerd Hoffmann wrote: > On Mi, 2014-09-24 at 11:47 +0000, Igor Mammedov wrote: > > along with it move common code fro ehci test to > > a separate file to avoid duplication. > > Having the code mode as separate patch makes it easier to see the actual > port test added ... I'll do it on respin. > > > +static void test_port_1(void) > > +{ > > + QPCIBus *pcibus; > > + struct qhc uhci; > > + > > + pcibus = qpci_init_pc(); > > + g_assert(pcibus != NULL); > > + usb_pci_init_one(pcibus, &uhci, QPCI_DEVFN(0x1d, 0), 4); > > + uhci_port_test(&uhci, 0, UHCI_PORT_CCS); > > } > > ... here. Why test only one of the two ports btw? Because I'd like to simplify* following hotplug test that uses port 2, no other ill intentions so far. *(use the same qtest_start(...) for all test until) > > cheers, > Gerd > >