Received: from eggs.gnu.org ([2001:4830:134:3::10]:35035) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWo53-0002kk-8k for qemu-devel@nongnu.org; Wed, 24 Sep 2014 11:02:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWo4t-00080E-W3 for qemu-devel@nongnu.org; Wed, 24 Sep 2014 11:02:09 -0400 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:37229) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWo4t-0007z2-ON for qemu-devel@nongnu.org; Wed, 24 Sep 2014 11:01:59 -0400 Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 24 Sep 2014 16:01:53 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 6F8832190066 for ; Wed, 24 Sep 2014 16:01:29 +0100 (BST) Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com [9.149.37.252]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s8OF1o1S18612424 for ; Wed, 24 Sep 2014 15:01:50 GMT Received: from d06av11.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s8OF1nMv011439 for ; Wed, 24 Sep 2014 09:01:50 -0600 Date: Wed, 24 Sep 2014 17:01:31 +0200 From: Cornelia Huck Message-ID: <20140924170131.36ce1e32.cornelia.huck@de.ibm.com> In-Reply-To: <20140924162056.63787016@nial.usersys.redhat.com> References: <1411559299-19042-1-git-send-email-imammedo@redhat.com> <20140924150144.7bdb7fb0.cornelia.huck@de.ibm.com> <20140924162056.63787016@nial.usersys.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/30] complete conversion to hotplug-handler API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: dmitry@daynix.com, mst@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, borntraeger@de.ibm.com, kraxel@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com, rth@twiddle.net On Wed, 24 Sep 2014 16:20:56 +0200 Igor Mammedov wrote: > Cornelia, > Thanks for testing, could you share your QEMU CLI and commands you use > for testing. Since it's surprise removal, I'll probably would be able > to debug it without working guest. > > BTW: > Is there a way to test it without s390 host+kvm, I've googled for > howto, but haven't found a working CLI+guest combination yet on > x86 fedora host? > I'm afraid you'll need an s390 host to test this :( However, here's what I did: /data/git/yyy/qemu/build/s390x-softmmu/qemu-system-s390x -machine s390-ccw-virtio,accel=kvm,usb=off,kernel_irqchip=on -m 1024 -smp 4 -nographic -drive file=/dev/sda,if=none,id=drive-virtio-disk0,format=raw,serial=ccwzfcp1,cache=none -device virtio-blk-ccw,devno=fe.0.0001,drive=drive-virtio-disk0,id=virtio-disk0,bootindex=1 -kernel /data/git/xxx/linux/arch/s390/boot/image -append "root=/dev/vda1" [root@localhost ~]# lscss Device Subchan. DevType CU Type Use PIM PAM POM CHPIDs ---------------------------------------------------------------------- 0.0.0000 0.0.0000 0000/00 3832/01 yes 80 80 ff 00000000 00000000 0.0.0001 0.0.0001 0000/00 3832/02 yes 80 80 ff 00000000 00000000 In the monitor: device_add virtio-balloon-ccw,id=xxx,devno=fe.2.1111 [root@localhost ~]# lscss Device Subchan. DevType CU Type Use PIM PAM POM CHPIDs ---------------------------------------------------------------------- 0.0.0000 0.0.0000 0000/00 3832/01 yes 80 80 ff 00000000 00000000 0.0.0001 0.0.0001 0000/00 3832/02 yes 80 80 ff 00000000 00000000 0.2.1111 0.2.0000 0000/00 3832/05 yes 80 80 ff 00000000 00000000 [root@localhost ~]# dmesg | grep CRW [ 26.098964] crw_info : CRW reports slct=0, oflw=0, chn=1, rsc=3, anc=0, erc=4, rsid=0 [ 26.098981] crw_info : CRW reports slct=0, oflw=0, chn=0, rsc=3, anc=0, erc=4, rsid=20 In the monitor: device_del xxx lscss in the guest now still shows the same output (the 0.2.1111 line should be gone), and no new crws show up in dmesg (there should be two further crws). I hope this is helpful. Let me know if there's something I can do (like stepping through qemu in gdb).