Received: from eggs.gnu.org ([2001:4830:134:3::10]:44956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXT3A-0005E8-N8 for qemu-devel@nongnu.org; Fri, 26 Sep 2014 06:47:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXT32-0002Ma-P6 for qemu-devel@nongnu.org; Fri, 26 Sep 2014 06:46:56 -0400 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:60060) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXT32-0002Lj-Fm for qemu-devel@nongnu.org; Fri, 26 Sep 2014 06:46:48 -0400 Received: from /spool/local by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 26 Sep 2014 11:46:41 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 9EFB02190043 for ; Fri, 26 Sep 2014 11:46:18 +0100 (BST) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s8QAkdwi46661800 for ; Fri, 26 Sep 2014 10:46:39 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s8QAkdpj023790 for ; Fri, 26 Sep 2014 04:46:39 -0600 Date: Fri, 26 Sep 2014 12:46:34 +0200 From: Cornelia Huck Message-ID: <20140926124634.10834b95.cornelia.huck@de.ibm.com> In-Reply-To: <1411723721-20484-1-git-send-email-imammedo@redhat.com> References: <1411723721-20484-1-git-send-email-imammedo@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 00/36] complete conversion to hotplug-handler API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: mst@redhat.com, amit.shah@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, borntraeger@de.ibm.com, kraxel@redhat.com, dmitry@daynix.com, pbonzini@redhat.com, rth@twiddle.net On Fri, 26 Sep 2014 09:28:05 +0000 Igor Mammedov wrote: > Changes since v1: > * added usb-uas test > * drop hotplug check in bus_add_child() > * make SCSI & USB bus as default HotplugHandler > * fixed dummy HBA hot(un)plug > * fixed hotunplug on s390x > * prevent hotplug of non hotpluggable devices > -- > > Series unifies different hotplug mechanisms to a recent > hotplug-handler API and does shallow conversion of > devices that still use legacy qdev hotplug to it dropping > not used after that legacy hotplug path [29/30]. > It also relaces SCSI's own way to do hotplug/unplug with > hotplug-handler callbacks leaving it the only method > perform hotplug tasks. > And the last patch [30/30] allows to unplug of BUS-less > devices using hotplug-handler API. > > Converted devices are covered with new hotplug > unit-tests, except of: > s390x-*: I have no idea how or means to test it, but code > is close to virtio, so it's converted using > virtio template > pvscsi: is broken, so no means to test it > > Git tree for testing: > https://github.com/imammedo/qemu/commits/hp_ctrl_conversion_v2 I've played around with attaching/detaching virtio devices on the s390-virtio and the s390-virtio-ccw machines. Everything seemed to work as before. I'll still take a look at the s390-related patches.