Received: from eggs.gnu.org ([2001:4830:134:3::10]:51625) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXTUw-0005DB-LL for qemu-devel@nongnu.org; Fri, 26 Sep 2014 07:15:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXTUm-0001Zo-BW for qemu-devel@nongnu.org; Fri, 26 Sep 2014 07:15:38 -0400 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:41618) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXTUm-0001Vg-1z for qemu-devel@nongnu.org; Fri, 26 Sep 2014 07:15:28 -0400 Received: from /spool/local by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 26 Sep 2014 12:15:21 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 9B7D71B08049 for ; Fri, 26 Sep 2014 12:16:29 +0100 (BST) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s8QBFIZg37290182 for ; Fri, 26 Sep 2014 11:15:19 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s8QBFIm2031652 for ; Fri, 26 Sep 2014 05:15:18 -0600 Date: Fri, 26 Sep 2014 13:15:16 +0200 From: Cornelia Huck Message-ID: <20140926131516.1535220d.cornelia.huck@de.ibm.com> In-Reply-To: <1411723721-20484-25-git-send-email-imammedo@redhat.com> References: <1411723721-20484-1-git-send-email-imammedo@redhat.com> <1411723721-20484-25-git-send-email-imammedo@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 24/36] s390x: convert s390-virtio to hotplug handler API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: mst@redhat.com, amit.shah@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, borntraeger@de.ibm.com, kraxel@redhat.com, dmitry@daynix.com, pbonzini@redhat.com, rth@twiddle.net On Fri, 26 Sep 2014 09:28:29 +0000 Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > v2: > fix not working unplug While the current code for s390-virtio implements unplug, the transport per se does not really support unplug (and never has), only hotplugging of devices. I removed the ->unplug callback and qemu now behaves like I'd expect: I can add devices with device_add, but device_del leaves them in place. That would be the way to go for me. > --- > hw/s390x/s390-virtio-bus.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-)