From: Yann E. MORIN Date: Tue, 30 Sep 2014 18:55:46 +0200 Subject: [Buildroot] [PATCH] freerdp: Add support for uClibc In-Reply-To: <1411567121-52400-1-git-send-email-Vincent.Riera@imgtec.com> References: <1411567121-52400-1-git-send-email-Vincent.Riera@imgtec.com> Message-ID: <20140930165546.GB4170@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Vicente, All, On 2014-09-24 14:58 +0100, Vicente Olivert Riera spake thusly: > The stable-1.1 branch of freerdp fails to build when using a uClibc > toolchain because it's using functions which are not implemented in > uClibc, like eventfd_read, eventfd_write and futimes. That is causing > build failures like these ones: > > ../../libwinpr/synch/libwinpr-synch.so.0.1.0: undefined reference to > `eventfd_read' > ../../libwinpr/synch/libwinpr-synch.so.0.1.0: undefined reference to > `eventfd_write' > > ../../common/libfreerdp-client.so.1.1.0: undefined reference to > `futimes' > > Apply an adapted upstream patch to add support for uClibc. > > Upstream patch: > https://github.com/FreeRDP/FreeRDP/commit/5f9c36da5d5cd3c5dce49f7b32fe011cb293f9ec/ > > Fixes: > http://autobuild.buildroot.net/results/a66/a66e1ab18cd12904a64afcbf54116ceef889e966/build-end.log > > Signed-off-by: Vicente Olivert Riera Sorry for missign this patch before I sent mine, disabling FreeRDP on uClibc. :-( So, I'll summarise our discussion on IRC: - you reference an upstream commit, but the patch you add to Buildroot is not exactly the same - that's because it's back-ported from their master, and it is touching files that do not exist in the stable-1.1 branch - we can't switch to using master, because it is too much in a flux for now Although you say in your commit log "adapted upstream patch", it is not clear enough (at least for me) what "adapted" means. It could be: - re-diffed to adapt to new line numbers - tweak name of variables that changed - trim non-applicable parts - ... This looks like nit-picking, but it is not obvious, so needs a bit of extra explanations. Like: Backport upstream patch, with non-applicable parts (new files from master, but not in the stable-1.1 branch) trimmed down: https://github.com/FreeRDP/FreeRDP/commit/5f9c36da5d5cd3c5dce49f7b32fe011cb293f9ec/ Otherwise the commit log is OK, and I'm fine with the change (I'll test it shortly.) Again, sorry for the mishap... :-/ Regards, Yann E. MORIN. > --- > .../freerdp-0001-add-support-for-uclibc.patch | 93 ++++++++++++++++++++ > 1 files changed, 93 insertions(+), 0 deletions(-) > create mode 100644 package/freerdp/freerdp-0001-add-support-for-uclibc.patch > > diff --git a/package/freerdp/freerdp-0001-add-support-for-uclibc.patch b/package/freerdp/freerdp-0001-add-support-for-uclibc.patch > new file mode 100644 > index 0000000..73f9807 > --- /dev/null > +++ b/package/freerdp/freerdp-0001-add-support-for-uclibc.patch > @@ -0,0 +1,93 @@ > +From be615daf41b4bcc61322a987088ee209b5e66c19 Mon Sep 17 00:00:00 2001 > +From: Vicente Olivert Riera > +Date: Wed, 24 Sep 2014 13:54:15 +0100 > +Subject: [PATCH] Add support for uClibc > + > +The stable-1.1 branch of freerdp fails to build when using a uClibc > +toolchain because it's using functions which are not implemented in > +uClibc, like eventfd_read, eventfd_write and futimes. That is causing > +build failures like these ones: > + > +../../libwinpr/synch/libwinpr-synch.so.0.1.0: undefined reference to > +`eventfd_read' > +../../libwinpr/synch/libwinpr-synch.so.0.1.0: undefined reference to > +`eventfd_write' > + > +../../common/libfreerdp-client.so.1.1.0: undefined reference to > +`futimes' > + > +This patch is based on this upstream patch: > + > + https://github.com/FreeRDP/FreeRDP/commit/5f9c36da5d5cd3c5dce49f7b32fe011cb293f9ec/ > + > +Signed-off-by: Vicente Olivert Riera > +--- > + channels/drive/client/drive_file.c | 12 +++++++++--- > + winpr/libwinpr/synch/event.c | 14 ++++++++++++++ > + 2 files changed, 23 insertions(+), 3 deletions(-) > + > +diff --git a/channels/drive/client/drive_file.c b/channels/drive/client/drive_file.c > +index 376b4fe..b20f408 100644 > +--- a/channels/drive/client/drive_file.c > ++++ b/channels/drive/client/drive_file.c > +@@ -480,7 +480,11 @@ BOOL drive_file_set_information(DRIVE_FILE* file, UINT32 FsInformationClass, UIN > + int status; > + char* fullpath; > + struct STAT st; > ++#if defined(ANDROID) > + struct timeval tv[2]; > ++#else > ++ struct timespec tv[2]; > ++#endif > + UINT64 LastWriteTime; > + UINT32 FileAttributes; > + UINT32 FileNameLength; > +@@ -501,15 +505,17 @@ BOOL drive_file_set_information(DRIVE_FILE* file, UINT32 FsInformationClass, UIN > + return FALSE; > + > + tv[0].tv_sec = st.st_atime; > +- tv[0].tv_usec = 0; > + tv[1].tv_sec = (LastWriteTime > 0 ? FILE_TIME_RDP_TO_SYSTEM(LastWriteTime) : st.st_mtime); > +- tv[1].tv_usec = 0; > + #ifndef WIN32 > + /* TODO on win32 */ > + #ifdef ANDROID > ++ tv[0].tv_usec = 0; > ++ tv[1].tv_usec = 0; > + utimes(file->fullpath, tv); > + #else > +- futimes(file->fd, tv); > ++ tv[0].tv_nsec = 0; > ++ tv[1].tv_nsec = 0; > ++ futimens(file->fd, tv); > + #endif > + > + if (FileAttributes > 0) > +diff --git a/winpr/libwinpr/synch/event.c b/winpr/libwinpr/synch/event.c > +index 173afaf..943cccb 100644 > +--- a/winpr/libwinpr/synch/event.c > ++++ b/winpr/libwinpr/synch/event.c > +@@ -115,6 +115,20 @@ HANDLE OpenEventA(DWORD dwDesiredAccess, BOOL bInheritHandle, LPCSTR lpName) > + return NULL; > + } > + > ++#ifdef HAVE_EVENTFD_H > ++#if defined(__UCLIBC__) > ++static int eventfd_read(int fd, eventfd_t* value) > ++{ > ++ return (read(fd, value, sizeof(*value)) == sizeof(*value)) ? 0 : -1; > ++} > ++ > ++static int eventfd_write(int fd, eventfd_t value) > ++{ > ++ return (write(fd, &value, sizeof(value)) == sizeof(value)) ? 0 : -1; > ++} > ++#endif > ++#endif > ++ > + BOOL SetEvent(HANDLE hEvent) > + { > + ULONG Type; > +-- > +1.7.1 > + > -- > 1.7.1 > > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'