From: Daniel Vetter Subject: Re: [PATCH 1/2 v3] drm/i915: intel_backlight scale() math WA Date: Tue, 30 Sep 2014 19:23:07 +0200 Message-ID: <20140930172307.GD12343@phenom.ffwll.local> References: <1412030973-16738-1-git-send-email-ullysses.a.eoff@intel.com> <1412030973-16738-2-git-send-email-ullysses.a.eoff@intel.com> <20140930080437.GD24667@phenom.ffwll.local> <1412089133.12349.49.camel@localhost> <20140930163135.GC12343@phenom.ffwll.local> <8B5BDC21C48FAF4CA5D7E3FE1A63A90870865B7A@ORSMSX111.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by gabe.freedesktop.org (Postfix) with ESMTP id 1373A6E314 for ; Tue, 30 Sep 2014 10:23:11 -0700 (PDT) Received: by mail-wi0-f173.google.com with SMTP id bs8so4907294wib.0 for ; Tue, 30 Sep 2014 10:23:11 -0700 (PDT) Content-Disposition: inline In-Reply-To: <8B5BDC21C48FAF4CA5D7E3FE1A63A90870865B7A@ORSMSX111.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Eoff, Ullysses A" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org On Tue, Sep 30, 2014 at 04:52:43PM +0000, Eoff, Ullysses A wrote: > > -----Original Message----- > > From: Daniel Vetter [mailto:daniel.vetter@ffwll.ch] On Behalf Of Daniel Vetter > > Sent: Tuesday, September 30, 2014 9:32 AM > > To: Eoff, Ullysses A > > Cc: daniel@ffwll.ch; intel-gfx@lists.freedesktop.org > > Subject: Re: [Intel-gfx] [PATCH 1/2 v3] drm/i915: intel_backlight scale() math WA > > > > On Tue, Sep 30, 2014 at 02:58:54PM +0000, Eoff, Ullysses A wrote: > > > On Tue, 2014-09-30 at 10:04 +0200, Daniel Vetter wrote: > > > > On Mon, Sep 29, 2014 at 03:49:32PM -0700, U. Artie Eoff wrote: > > > > > Improper truncated integer division in the scale() function causes > > > > > actual_brightness != brightness. This (partial) work-around should be > > > > > sufficient for a majority of use-cases, but it is by no means a complete > > > > > solution. > > > > > > > > > > TODO: Determine how best to scale "user" values to "hw" values, and > > > > > vice-versa, when the ranges are of different sizes. That would be a > > > > > buggy scenario even with this work-around. > > > > > > > > > > The issue was introduced in the following (v3.17-rc1) commit: > > > > > > > > > > 6dda730 drm/i915: respect the VBT minimum backlight brightness > > > > > > > > > > v2: (thanks to Chris Wilson) clarify commit message, use rounded division > > > > > macro > > > > > > > > > > v3: -DIV_ROUND_CLOSEST() fails to build with CONFIG_X86_32=y. (Jani) > > > > > -Use DIV_ROUND_CLOSEST_ULL() instead. (Damien) > > > > > -v1 and v2 originally authored by Joe Konno. > > > > > > > > > > Signed-off-by: U. Artie Eoff > > > > > > > > Is there some bug report, internal jira, mailing list reference or similar > > > > about this? > > > > > > > > Note that at least for OTC jira tasks we now want them to be added to > > > > commit message with e.g. > > > > > > > > OTC-Jria: VIZ-4932 > > > > > > > > > > Yes, the OTC-Jira task is: VIZ-4395. I'll resubmit with amended commit > > > message. > > > > > > > And I guess I should merge patch 2 before patch 1, right? > > > > > > No, patch 1 before patch 2. > > > > Oh, I didn't notice that your first add a duplicated version of the macro > > and then unify it. That's a bit backwards ... > > The reason for doing it this way is so we can cherry-pick patch 1 into the > chromeos 3.10 kernel cleanly (with some other backlight patches). > That is, patch 1 is decoupled from the changes in intel_display.c. > Hope that makes sense. Yeah. Would be good to mention that in the commit message, e.g. "For easier backporting Duplicate the division macro here and refactor the code in a follow-up patch". I'll add that when merging if you don't resend. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch