From: Ezequiel Garcia Subject: Re: [PATCH v4] mtd: ubi: Extend UBI layer debug/messaging capabilities Date: Tue, 14 Oct 2014 11:39:02 -0300 Message-ID: <20141014143902.GA9768@arch.hh.imgtec.org> References: <1413296037-22346-1-git-send-email-tlinder@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from top.free-electrons.com ([176.31.233.9]:55298 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932145AbaJNOka (ORCPT ); Tue, 14 Oct 2014 10:40:30 -0400 Content-Disposition: inline In-Reply-To: <1413296037-22346-1-git-send-email-tlinder@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Tanya Brokhman Cc: dedekind1@gmail.com, linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org, David Woodhouse , Brian Norris , Richard Weinberger , open list On 14 Oct 05:13 PM, Tanya Brokhman wrote: > diff --git a/drivers/mtd/ubi/block.c b/drivers/mtd/ubi/block.c > index 8876c7d..3532f8a 100644 > --- a/drivers/mtd/ubi/block.c > +++ b/drivers/mtd/ubi/block.c > @@ -111,12 +111,12 @@ static int __init ubiblock_set_param(const char= *val, > =20 > len =3D strnlen(val, UBIBLOCK_PARAM_LEN); > if (len =3D=3D 0) { > - ubi_warn("block: empty 'block=3D' parameter - ignored\n"); > + pr_warn("block: empty 'block=3D' parameter - ignored\n"); No, this is wrong. The message should say something like "UBI: block", = or otherwise the user will think this comes from the block subsystem. Please use some pr_fmt for this. Something like this before the headers should be enough: #define pr_fmt(fmt) "UBI: block:" fmt You can then use pr_{info,warn,err} without the prefix like this: pr_info("whatever"); Which prints "UBI: block: whatever". See arch/arm/kernel/perf_event.c for an example of how this works. Also: > if (len =3D=3D UBIBLOCK_PARAM_LEN) { > - ubi_err("block: parameter \"%s\" is too long, max. is %= d\n", > + pr_warn("block: parameter \"%s\" is too long, max. is %= d\n", > val, UBIBLOCK_PARAM_LEN); > return -EINVAL; > } Please replace the level properly ubi_err -> pr_err, ubi_warn -> pr_war= n, etc. --=20 Ezequiel Garc=EDa, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com