From: Wei Liu Subject: Re: [OPW PATCH] tools/xl: Call init function for libxl_domain_sched_params Date: Fri, 17 Oct 2014 11:14:11 +0100 Message-ID: <20141017101411.GC2844@zion.uk.xensource.com> References: <544049a4.8937460a.770a.6430@mx.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <544049a4.8937460a.770a.6430@mx.google.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Uma Sharma Cc: George.Dunlap@eu.citrix.com, Ian.Jackson@citrix.com, Wei.Liu2@citrix.com, Ian.Campbell@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Fri, Oct 17, 2014 at 04:11:33AM +0530, Uma Sharma wrote: > This patch calls init function for libxl_domain_sched_params before passing it as reference to sched_domain_get() function in tools/libxl/xl_cmdimpl.c > IDL generated libxl types should be used only after calling the init function even if the variable is simply being passed by reference as an output parameter to a libxl function. > The commit log line is too long. We normally have 72 or 80 column per line. I don't think you need to resend this patch just to reformat commit log. But it would be better to configure your editor to line-wrap automatically for you in the future. > Signed-off-by: Uma Sharma Acked-by: Wei Liu Thanks for your contribution! Wei.