From: Damien Lespiau Subject: Re: [PATCH] drm/i915: Emit even number of dwords when emitting LRIs Date: Wed, 22 Oct 2014 11:54:08 +0100 Message-ID: <20141022105408.GB3470@strange.amr.corp.intel.com> References: <1413968989-16840-1-git-send-email-arun.siluvery@linux.intel.com> <20141022104030.GA3470@strange.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 257FD6E2CE for ; Wed, 22 Oct 2014 03:54:11 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20141022104030.GA3470@strange.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Arun Siluvery Cc: intel-gfx@lists.freedesktop.org, Mika Kuoppala List-Id: intel-gfx@lists.freedesktop.org On Wed, Oct 22, 2014 at 11:40:30AM +0100, Damien Lespiau wrote: > On Wed, Oct 22, 2014 at 10:09:49AM +0100, Arun Siluvery wrote: > > The number of DWords should be even when doing ring emits as > > command sequences require QWord alignment. > > It looks like we could just pad at the end of the batch instead of one > NOP per register write? > > Also, It looks like we could use the LRI variant that can write more > than one register in one go (separate patch)?. Note that if you use the multi-register LRI variant, the number of dwords will always be odd, so we'll always need to pad a NOP, that makes it easy. -- Damien