Received: from eggs.gnu.org ([2001:4830:134:3::10]:44108)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1Xgy93-0005mf-R1
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 11:48:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1Xgy8z-0001BO-87
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 11:48:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:11554)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1Xgy8z-0001B2-0S
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 11:48:13 -0400
Date: Wed, 22 Oct 2014 17:48:03 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20141022174803.06be932f@nial.usersys.redhat.com>
In-Reply-To: <cover.1413770236.git.zhugh.fnst@cn.fujitsu.com>
References: <cover.1413770236.git.zhugh.fnst@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 0/3] monitor: add peripheral device del
 completion support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Zhu Guihua <zhugh.fnst@cn.fujitsu.com>
Cc: peter.crosthwaite@xilinx.com, mst@redhat.com, hutao@cn.fujitsu.com, qemu-devel@nongnu.org, armbru@redhat.com, isimatu.yasuaki@jp.fujitsu.com, tangchen@cn.fujitsu.com, pbonzini@redhat.com, lcapitulino@redhat.com, afaerber@suse.de

On Tue, 21 Oct 2014 19:46:03 +0800
Zhu Guihua <zhugh.fnst@cn.fujitsu.com> wrote:

> After inputting device_del command in monitor, we expect to list all
> hotpluggable devices automatically by pressing tab key. This patchset provides
> the function to list all peripheral devices such as memory devices.
> 
> v5:
> - In patch 2, make list to free (Marcel)
> 
> v4:
> - Delete unused device_del_bus_completion (Igor)
> - Modify the way to get value of hotpluggable property (Igor)
> 
> v3:
> - Commit message changes (Igor)
> - Rename function in patch 1 (Igor)
> - Use 'hotpluggable' property to discard non-hotpluggable devices (Igor)
> 
> v2:
> - Use object_child_foreach() to simplify the implementation (Andreas)
> 
> 
> Zhu Guihua (3):
>   qdev: add qdev_build_hotpluggable_device_list helper
>   monitor: add del completion for peripheral device
>   monitor: delete device_del_bus_completion
> 
>  hw/core/qdev.c         | 13 +++++++++++++
>  include/hw/qdev-core.h |  2 ++
>  monitor.c              | 28 +++++++++++++++++-----------
>  3 files changed, 32 insertions(+), 11 deletions(-)
> 
For series:

Reviewed-by: Igor Mammedov <imammedo@redhat.com>