From: "J. Bruce Fields" Subject: Re: Intentionally corrupted vfat fs causing BUG Date: Thu, 23 Oct 2014 13:54:28 -0400 Message-ID: <20141023175428.GB22339@fieldses.org> References: <543B8BC7.1040501@nod.at> <87y4sk5pul.fsf@devron.myhome.or.jp> <543B8FA7.9000106@nod.at> <87r3yc5oqt.fsf@devron.myhome.or.jp> <5443E87A.2060207@nod.at> <87oat29551.fsf@devron.myhome.or.jp> <20141023160106.GB7996@ZenIV.linux.org.uk> <20141023161606.GC7996@ZenIV.linux.org.uk> <877fzq91ky.fsf@devron.myhome.or.jp> <20141023165533.GD7996@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: OGAWA Hirofumi , Richard Weinberger , Sami Liedes , linux-fsdevel To: Al Viro Return-path: Received: from fieldses.org ([174.143.236.118]:51212 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751721AbaJWRyr (ORCPT ); Thu, 23 Oct 2014 13:54:47 -0400 Content-Disposition: inline In-Reply-To: <20141023165533.GD7996@ZenIV.linux.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Oct 23, 2014 at 05:55:33PM +0100, Al Viro wrote: > On Fri, Oct 24, 2014 at 01:45:49AM +0900, OGAWA Hirofumi wrote: > > > d_splice_alias() calls __d_find_alias() with want_discon==1, so > > __d_find_alias() doesn't return dentry, and d_splice_alias() doesn't use > > d_move() path, right? > > Hmm... Not in the current mainline (and not because of want_discon - that's > gone already). However, with the fixes I've got in the local tree it > will both find and move it - same as d_materialise_unique() would in the > current mainline. What happened to the idea of failing with -EIO in that case? In the case of a disk filesystem it seems like it can only happen due to corruption and I'd assumed we're better off failing the first time we notice it. (That said, I haven't thought it through beyond that, so it's not something I have that strong an opinion on.) --b.