From: Tejun Heo Subject: Re: [PATCH libata/for-3.18-fixes] Revert "AHCI: Optimize single IRQ interrupt processing" Date: Mon, 27 Oct 2014 12:03:48 -0400 Message-ID: <20141027160348.GT4436@htj.dyndns.org> References: <1414082970-20775-1-git-send-email-marc.zyngier@arm.com> <20141027132045.GA30198@agordeev.usersys.redhat.com> <20141027135802.GI4436@htj.dyndns.org> <20141027160546.GB30198@agordeev.usersys.redhat.com> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20141027160546.GB30198-QOHinCyTyHu/4bX3TIDHR/XAX3CI6PSWQQ4Iyu8u01E@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Content-Disposition: inline To: Alexander Gordeev Cc: Marc Zyngier , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-ide@vger.kernel.org On Mon, Oct 27, 2014 at 04:05:47PM +0000, Alexander Gordeev wrote: > On Mon, Oct 27, 2014 at 09:58:02AM -0400, Tejun Heo wrote: > > From 61e268068c92ed000f078dc1ab71d1228439fecd Mon Sep 17 00:00:00 2001 > > From: Tejun Heo > > Date: Mon, 27 Oct 2014 09:50:36 -0400 > > > > This reverts commit 18dcf433f3ded61eb140a55e7048ec2fef79e723. > > IRQF_ONESHOT was missing from the conversion causing screaming > > interrupts problems on some setups and LKP detected measureable drop > > in IO performance. It looks like we'll first need to drop the > > threaded IRQ handling first before splitting locking. > > Tejun, > > Sorry for missing to mention - I think it is better to revert 33fb0d0 > ("AHCI: Do not acquire ata_host::lock from single IRQ handler") first, > unless you examined it is fine to leave (I did not). Alright, redid the revert and rebased the tree. Can you please take a look at libata/for-3.18-fixes and see whether it looks okay? Thanks. -- tejun