From: Jesse Barnes Subject: Re: [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode v2 Date: Fri, 31 Oct 2014 15:48:02 -0700 Message-ID: <20141031154802.080b53a0@jbarnes-t420> References: <1414695244-14159-1-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pd0-f170.google.com (mail-pd0-f170.google.com [209.85.192.170]) by gabe.freedesktop.org (Postfix) with ESMTP id 720766E7C6 for ; Fri, 31 Oct 2014 15:48:13 -0700 (PDT) Received: by mail-pd0-f170.google.com with SMTP id z10so8110648pdj.1 for ; Fri, 31 Oct 2014 15:48:13 -0700 (PDT) In-Reply-To: <1414695244-14159-1-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org, shuang.he@linux.intel.com List-Id: intel-gfx@lists.freedesktop.org VGhhbmtzIGZvciB0aGUgcmV2aWV3LCBBbmRlci4KCkRhbmllbCwgaW4gY2FzZSB5b3UncmUgdGVt cHRlZCB0byBtZXJnZSB0aGlzLCBkb24ndCBqdXN0IHlldC4gIFNoYXVuZydzCnRlc3QgYm90IGZv dW5kIGFuIGlzc3VlIHdpdGggdGhlIHJlZmFjdG9yaW5nIHBhdGNoIEknbSBzdGlsbCB0cmFja2lu Zwpkb3duLiAgSSdsbCBwb3N0IGEgdjMgd2l0aCB0aGUgZml4IGluIHJlcGx5IHRvIHRoaXMuLi4K ClRoYW5rcywKSmVzc2UKCk9uIFRodSwgMzAgT2N0IDIwMTQgMTE6NTM6NTkgLTA3MDAKSmVzc2Ug QmFybmVzIDxqYmFybmVzQHZpcnR1b3VzZ2Vlay5vcmc+IHdyb3RlOgoKPiBUaGlzIGFsbG93cyB1 cyB0byBjYWxjdWxhdGUgdGhlIGZ1bGwgcGlwZSBjb25maWcgYmVmb3JlIHdlIGRvIGFueSBtb2Rl Cj4gc2V0dGluZyB3b3JrLgo+IAo+IHYyOgo+ICAgLSBjbGFyaWZ5IGNvbW1lbnRzIGFib3V0IGds b2JhbCB2cy4gcGVyLWNydGMgbW9kZSBzZXQgKEFuZGVyKQo+ICAgLSBjbGVhbiB1cCB1bm5lY2Vz c2FyeSBwaXBlX2NvbmZpZyA9IE5VTEwgc2V0dGluZyAoQW5kZXIpCj4gCj4gU2lnbmVkLW9mZi1i eTogSmVzc2UgQmFybmVzIDxqYmFybmVzQHZpcnR1b3VzZ2Vlay5vcmc+Cj4gLS0tCj4gIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDk2Cj4gKysrKysrKysrKysrKysrKysr KysrKysrKy0tLS0tLS0tLS0tIDEgZmlsZSBjaGFuZ2VkLCA2OAo+IGluc2VydGlvbnMoKyksIDI4 IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kaXNwbGF5LmMKPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBpbmRl eCA2ZTViYzNjLi5mOWEwOTYzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXku Ywo+IEBAIC0xMDkxMCw0NSArMTA5MTAsNjEgQEAgc3RhdGljIHZvaWQgdXBkYXRlX3NjYW5saW5l X29mZnNldChzdHJ1Y3QKPiBpbnRlbF9jcnRjICpjcnRjKSBjcnRjLT5zY2FubGluZV9vZmZzZXQg PSAxOwo+ICB9Cj4gIAo+ICtzdGF0aWMgaW50IGludGVsX21vZGVzZXRfY29tcHV0ZV9jb25maWco c3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICsJCQkJCXN0cnVjdCBkcm1fZGlzcGxheV9tb2RlCj4g Km1vZGUsCj4gKwkJCQkJc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIsCj4gKwkJCQkJdW5zaWdu ZWQgKm1vZGVzZXRfcGlwZXMsCj4gKwkJCQkJdW5zaWduZWQgKnByZXBhcmVfcGlwZXMsCj4gKwkJ CQkJdW5zaWduZWQgKmRpc2FibGVfcGlwZXMpCj4gK3sKPiArCXN0cnVjdCBpbnRlbF9jcnRjX2Nv bmZpZyAqcGlwZV9jb25maWcgPSBOVUxMOwo+ICsJaW50IHJldCA9IDA7Cj4gKwo+ICsJaW50ZWxf bW9kZXNldF9hZmZlY3RlZF9waXBlcyhjcnRjLCBtb2Rlc2V0X3BpcGVzLAo+ICsJCQkJICAgICBw cmVwYXJlX3BpcGVzLCBkaXNhYmxlX3BpcGVzKTsKPiArCj4gKwlpZiAoIW1vZGVzZXRfcGlwZXMp Cj4gKwkJZ290byBvdXQ7Cj4gKwo+ICsJLyoKPiArCSAqIE5vdGUgdGhpcyBuZWVkcyBjaGFuZ2Vz IHdoZW4gd2Ugc3RhcnQgdHJhY2tpbmcgbXVsdGlwbGUKPiBtb2Rlcwo+ICsJICogYW5kIGNydGNz LiAgQXQgdGhhdCBwb2ludCB3ZSdsbCBuZWVkIHRvIGNvbXB1dGUgdGhlIHdob2xlCj4gY29uZmln Cj4gKwkgKiAoaS5lLiBvbmUgcGlwZV9jb25maWcgZm9yIGVhY2ggY3J0YykgcmF0aGVyIHRoYW4g anVzdCB0aGUKPiBvbmUKPiArCSAqIGZvciB0aGlzIGNydGMuCj4gKwkgKi8KPiArCXBpcGVfY29u ZmlnID0gaW50ZWxfbW9kZXNldF9waXBlX2NvbmZpZyhjcnRjLCBmYiwgbW9kZSk7Cj4gKwlpZiAo SVNfRVJSKHBpcGVfY29uZmlnKSkgewo+ICsJCXJldCA9IFBUUl9FUlIocGlwZV9jb25maWcpOwo+ ICsJCWdvdG8gb3V0Owo+ICsJfQo+ICsJaW50ZWxfZHVtcF9waXBlX2NvbmZpZyh0b19pbnRlbF9j cnRjKGNydGMpLCBwaXBlX2NvbmZpZywKPiArCQkJICAgICAgICJbbW9kZXNldF0iKTsKPiArCXRv X2ludGVsX2NydGMoY3J0YyktPm5ld19jb25maWcgPSBwaXBlX2NvbmZpZzsKPiArCj4gK291dDoK PiArCXJldHVybiByZXQ7Cj4gK30KPiArCj4gIHN0YXRpYyBpbnQgX19pbnRlbF9zZXRfbW9kZShz dHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gIAkJCSAgICBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAq bW9kZSwKPiAtCQkJICAgIGludCB4LCBpbnQgeSwgc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIp Cj4gKwkJCSAgICBpbnQgeCwgaW50IHksIHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiLAo+ICsJ CQkgICAgdW5zaWduZWQgZGlzYWJsZV9waXBlcywKPiArCQkJICAgIHVuc2lnbmVkIHByZXBhcmVf cGlwZXMsCj4gKwkJCSAgICB1bnNpZ25lZCBtb2Rlc2V0X3BpcGVzKQo+ICB7Cj4gIAlzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2ID0gY3J0Yy0+ZGV2Owo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiAgCXN0cnVjdCBkcm1fZGlzcGxheV9tb2Rl ICpzYXZlZF9tb2RlOwo+ICAJc3RydWN0IGludGVsX2NydGNfY29uZmlnICpwaXBlX2NvbmZpZyA9 IE5VTEw7Cj4gIAlzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YzsKPiAtCXVuc2lnbmVkIGRp c2FibGVfcGlwZXMsIHByZXBhcmVfcGlwZXMsIG1vZGVzZXRfcGlwZXM7Cj4gIAlpbnQgcmV0ID0g MDsKPiAgCj4gIAlzYXZlZF9tb2RlID0ga21hbGxvYyhzaXplb2YoKnNhdmVkX21vZGUpLCBHRlBf S0VSTkVMKTsKPiAgCWlmICghc2F2ZWRfbW9kZSkKPiAgCQlyZXR1cm4gLUVOT01FTTsKPiAgCj4g LQlpbnRlbF9tb2Rlc2V0X2FmZmVjdGVkX3BpcGVzKGNydGMsICZtb2Rlc2V0X3BpcGVzLAo+IC0J CQkJICAgICAmcHJlcGFyZV9waXBlcywgJmRpc2FibGVfcGlwZXMpOwo+IC0KPiAgCSpzYXZlZF9t b2RlID0gY3J0Yy0+bW9kZTsKPiAgCj4gLQkvKiBIYWNrOiBCZWNhdXNlIHdlIGRvbid0ICh5ZXQp IHN1cHBvcnQgZ2xvYmFsIG1vZGVzZXQgb24KPiBtdWx0aXBsZQo+IC0JICogY3J0Y3MsIHdlIGRv bid0IGtlZXAgdHJhY2sgb2YgdGhlIG5ldyBtb2RlIGZvciBtb3JlIHRoYW4KPiBvbmUgY3J0Yy4K PiAtCSAqIEhlbmNlIHNpbXBseSBjaGVjayB3aGV0aGVyIGFueSBiaXQgaXMgc2V0IGluCj4gbW9k ZXNldF9waXBlcyBpbiBhbGwgdGhlCj4gLQkgKiBwaWVjZXMgb2YgY29kZSB0aGF0IGFyZSBub3Qg eWV0IGNvbnZlcnRlZCB0byBkZWFsIHdpdGgKPiBtdXRsaXBsZSBjcnRjcwo+IC0JICogY2hhbmdp bmcgdGhlaXIgbW9kZSBhdCB0aGUgc2FtZSB0aW1lLiAqLwo+IC0JaWYgKG1vZGVzZXRfcGlwZXMp IHsKPiAtCQlwaXBlX2NvbmZpZyA9IGludGVsX21vZGVzZXRfcGlwZV9jb25maWcoY3J0YywgZmIs Cj4gbW9kZSk7Cj4gLQkJaWYgKElTX0VSUihwaXBlX2NvbmZpZykpIHsKPiAtCQkJcmV0ID0gUFRS X0VSUihwaXBlX2NvbmZpZyk7Cj4gLQkJCXBpcGVfY29uZmlnID0gTlVMTDsKPiAtCj4gLQkJCWdv dG8gb3V0Owo+IC0JCX0KPiAtCQlpbnRlbF9kdW1wX3BpcGVfY29uZmlnKHRvX2ludGVsX2NydGMo Y3J0YyksCj4gcGlwZV9jb25maWcsCj4gLQkJCQkgICAgICAgIlttb2Rlc2V0XSIpOwo+IC0JCXRv X2ludGVsX2NydGMoY3J0YyktPm5ld19jb25maWcgPSBwaXBlX2NvbmZpZzsKPiAtCX0KPiAtCj4g IAkvKgo+ICAJICogU2VlIGlmIHRoZSBjb25maWcgcmVxdWlyZXMgYW55IGFkZGl0aW9uYWwgcHJl cGFyYXRpb24sCj4gZS5nLgo+ICAJICogdG8gYWRqdXN0IGdsb2JhbCBzdGF0ZSB3aXRoIHBpcGVz IG9mZi4gIFdlIG5lZWQgdG8gZG8gdGhpcwo+IEBAIC0xMDk3Myw2ICsxMDk4OSwxMCBAQCBzdGF0 aWMgaW50IF9faW50ZWxfc2V0X21vZGUoc3RydWN0IGRybV9jcnRjCj4gKmNydGMsIAo+ICAJLyog Y3J0Yy0+bW9kZSBpcyBhbHJlYWR5IHVzZWQgYnkgdGhlIC0+bW9kZV9zZXQgY2FsbGJhY2tzLAo+ IGhlbmNlIHdlIG5lZWQKPiAgCSAqIHRvIHNldCBpdCBoZXJlIGFscmVhZHkgZGVzcGl0ZSB0aGF0 IHdlIHBhc3MgaXQgZG93biB0aGUKPiBjYWxsY2hhaW4uCj4gKwkgKgo+ICsJICogTm90ZSB3ZSds bCBuZWVkIHRvIGZpeCB0aGlzIHVwIHdoZW4gd2Ugc3RhcnQgdHJhY2tpbmcKPiBtdWx0aXBsZQo+ ICsJICogcGlwZXM7IGhlcmUgd2UgYXNzdW1lIGEgc2luZ2xlIG1vZGVzZXRfcGlwZSBhbmQgb25s eQo+IHRyYWNrIHRoZQo+ICsJICogc2luZ2xlIGNydGMgYW5kIG1vZGUuCj4gIAkgKi8KPiAgCWlm IChtb2Rlc2V0X3BpcGVzKSB7Cj4gIAkJY3J0Yy0+bW9kZSA9ICptb2RlOwo+IEBAIC0xMTA0Miwx OSArMTEwNjIsMjIgQEAgZG9uZToKPiAgCWlmIChyZXQgJiYgY3J0Yy0+ZW5hYmxlZCkKPiAgCQlj cnRjLT5tb2RlID0gKnNhdmVkX21vZGU7Cj4gIAo+IC1vdXQ6Cj4gIAlrZnJlZShwaXBlX2NvbmZp Zyk7Cj4gIAlrZnJlZShzYXZlZF9tb2RlKTsKPiAgCXJldHVybiByZXQ7Cj4gIH0KPiAgCj4gLXN0 YXRpYyBpbnQgaW50ZWxfc2V0X21vZGUoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+IC0JCQkgIHN0 cnVjdCBkcm1fZGlzcGxheV9tb2RlICptb2RlLAo+IC0JCQkgIGludCB4LCBpbnQgeSwgc3RydWN0 IGRybV9mcmFtZWJ1ZmZlciAqZmIpCj4gK3N0YXRpYyBpbnQgaW50ZWxfc2V0X21vZGVfcGlwZXMo c3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICsJCQkJc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1v ZGUsCj4gKwkJCQlpbnQgeCwgaW50IHksIHN0cnVjdCBkcm1fZnJhbWVidWZmZXIKPiAqZmIsCj4g KwkJCQl1bnNpZ25lZCBtb2Rlc2V0X3BpcGVzLAo+ICsJCQkJdW5zaWduZWQgcHJlcGFyZV9waXBl cywKPiArCQkJCXVuc2lnbmVkIGRpc2FibGVfcGlwZXMpCj4gIHsKPiAgCWludCByZXQ7Cj4gIAo+ IC0JcmV0ID0gX19pbnRlbF9zZXRfbW9kZShjcnRjLCBtb2RlLCB4LCB5LCBmYik7Cj4gKwlyZXQg PSBfX2ludGVsX3NldF9tb2RlKGNydGMsIG1vZGUsIHgsIHksIGZiLCBtb2Rlc2V0X3BpcGVzLAo+ ICsJCQkgICAgICAgcHJlcGFyZV9waXBlcywgZGlzYWJsZV9waXBlcyk7Cj4gIAo+ICAJaWYgKHJl dCA9PSAwKQo+ICAJCWludGVsX21vZGVzZXRfY2hlY2tfc3RhdGUoY3J0Yy0+ZGV2KTsKPiBAQCAt MTEwNjIsNiArMTEwODUsMjMgQEAgc3RhdGljIGludCBpbnRlbF9zZXRfbW9kZShzdHJ1Y3QgZHJt X2NydGMKPiAqY3J0YywgcmV0dXJuIHJldDsKPiAgfQo+ICAKPiArc3RhdGljIGludCBpbnRlbF9z ZXRfbW9kZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gKwkJCSAgc3RydWN0IGRybV9kaXNwbGF5 X21vZGUgKm1vZGUsCj4gKwkJCSAgaW50IHgsIGludCB5LCBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVy ICpmYikKPiArewo+ICsJdW5zaWduZWQgbW9kZXNldF9waXBlcywgcHJlcGFyZV9waXBlcywgZGlz YWJsZV9waXBlczsKPiArCWludCByZXQ7Cj4gKwo+ICsJcmV0ID0gaW50ZWxfbW9kZXNldF9jb21w dXRlX2NvbmZpZyhjcnRjLCBtb2RlLCBmYiwKPiArCQkJCQkgICAmbW9kZXNldF9waXBlcywKPiAm cHJlcGFyZV9waXBlcywKPiArCQkJCQkgICAmZGlzYWJsZV9waXBlcyk7Cj4gKwlpZiAocmV0KQo+ ICsJCXJldHVybiByZXQ7Cj4gKwo+ICsJcmV0dXJuIGludGVsX3NldF9tb2RlX3BpcGVzKGNydGMs IG1vZGUsIHgsIHksIGZiLAo+IG1vZGVzZXRfcGlwZXMsCj4gKwkJCQkgICAgcHJlcGFyZV9waXBl cywgZGlzYWJsZV9waXBlcyk7Cj4gK30KPiArCj4gIHZvaWQgaW50ZWxfY3J0Y19yZXN0b3JlX21v ZGUoc3RydWN0IGRybV9jcnRjICpjcnRjKQo+ICB7Cj4gIAlpbnRlbF9zZXRfbW9kZShjcnRjLCAm Y3J0Yy0+bW9kZSwgY3J0Yy0+eCwgY3J0Yy0+eSwKPiBjcnRjLT5wcmltYXJ5LT5mYik7CgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=