From: Daniel Vetter Subject: Re: [PATCH 4/9] drm/i915: Add infrastructure for choosing DPLLs before disabling crtcs Date: Mon, 3 Nov 2014 14:51:27 +0100 Message-ID: <20141103135127.GF26941@phenom.ffwll.local> References: <1414575158-28148-1-git-send-email-ander.conselvan.de.oliveira@intel.com> <1414575158-28148-5-git-send-email-ander.conselvan.de.oliveira@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by gabe.freedesktop.org (Postfix) with ESMTP id 806C76E29C for ; Mon, 3 Nov 2014 05:51:14 -0800 (PST) Received: by mail-wi0-f175.google.com with SMTP id ex7so6529655wid.2 for ; Mon, 03 Nov 2014 05:51:13 -0800 (PST) Content-Disposition: inline In-Reply-To: <1414575158-28148-5-git-send-email-ander.conselvan.de.oliveira@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ander Conselvan de Oliveira Cc: intel-gfx@lists.freedesktop.org, ville.syrjala@intel.com, shuang.he@linux.intel.com List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBPY3QgMjksIDIwMTQgYXQgMTE6MzI6MzNBTSArMDIwMCwgQW5kZXIgQ29uc2VsdmFu IGRlIE9saXZlaXJhIHdyb3RlOgo+IEl0IGlzIHBvc3NpYmxlIGZvciBhIG1vZGUgc2V0IHRvIGZh aWwgaWYgdGhlcmUgYXJlbid0IHNoYXJlZCBEUExMUyB0aGF0Cj4gbWF0Y2ggdGhlIG5ldyBjb25m aWd1cmF0aW9uIHJlcXVpcmVtZW50IG9yIG90aGVyIGVycm9ycyBpbiBjbG9jawo+IGNvbXB1dGF0 aW9uLiBJZiB0aGF0IHN0ZXAgaXMgZXhlY3V0ZWQgYWZ0ZXIgZGlzYWJsaW5nIGNydGNzLCBpbiB0 aGUKPiBmYWlsdXJlIGNhc2UgdGhlIGhhcmR3YXJlIGNvbmZpZ3VyYXRpb24gaXMgY2hhbmdlZCBh bmQgbmVlZHMgdG8gYmUKPiByZXN0b3JlZC4gRG9pbmcgdGhvc2UgdGhpbmdzIGVhcmx5IHdpbGwg YWxsb3cgdGhlIG1vZGUgc2V0IHRvIGZhaWwKPiBiZWZvcmUgYWN0dWFsbHkgdG91Y2hpbmcgdGhl IGhhcmR3YXJlLgo+IAo+IEZvbGxvdyB1cCBwYXRjaGVzIHdpbGwgY29udmVydCBkaWZmZXJlbnQg cGxhdGZvcm1zIHRvIHVzZSB0aGUgbmV3Cj4gaW5mcmFzdHJ1Y3R1cmUuCj4gCj4gdjI6IEtlZXAg cGxsLT5uZXdfY29uZmlnIHZhbGlkIG9ubHkgZHVyaW5nIG1vZGUgc2V0IChWaWxsZSkKPiAgICAg VXNlIGttZW1kdXAoKSBpbiBpOTE1X3NoYXJlZF9kcGxsX3N0YXJ0X2NvbmZpZygpIChWaWxsZSkK PiAgICAgUmVzdG9yZSBvbGQgcGxsIGNvbmZpZyBpZiBzb21ldGhpbmcgZmFpbHMgYmVmb3JlIGNv bW1pdCAoVmlsbGUpCj4gICAgIERvbid0IHNldCBjb21wdXRlX2Nsb2NrIGhvb2tzIHNpbmNlIGRl dl9wcml2IGlzIGt6YWxsb2MoKSdkIChWaWxsZSkKPiAKPiBTaWduZWQtb2ZmLWJ5OiBBbmRlciBD b25zZWx2YW4gZGUgT2xpdmVpcmEgPGFuZGVyLmNvbnNlbHZhbi5kZS5vbGl2ZWlyYUBpbnRlbC5j b20+CgpSYW4gaW50byBhIGJsb2NraW5nIHF1ZXN0aW9uIHdpdGggdGhpcyBvbmUsIG1lcmdlZCB0 aHVzIGZhci4KCj4gQEAgLTczOTUsNiArNzQ1Niw5IEBAIHN0YXRpYyBpbnQgaXJvbmxha2VfY3J0 Y19tb2RlX3NldChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiAgCQllbHNlCj4gIAkJCWNydGMt Pm5ld19jb25maWctPmRwbGxfaHdfc3RhdGUuZnAxID0gZnA7Cj4gIAo+ICsJCWlmIChpbnRlbF9j cnRjX3RvX3NoYXJlZF9kcGxsKGNydGMpKQo+ICsJCQlpbnRlbF9wdXRfc2hhcmVkX2RwbGwoY3J0 Yyk7CgpEb24ndCB3ZSBuZWVkIHRoZSBzYW1lIGZpeHVwIGluIGludGVsX2RkaV9wbGxfc2VsZWN0 Pwo+ICsKPiAgCQlwbGwgPSBpbnRlbF9nZXRfc2hhcmVkX2RwbGwoY3J0Yyk7Cj4gIAkJaWYgKHBs bCA9PSBOVUxMKSB7Cj4gIAkJCURSTV9ERUJVR19EUklWRVIoImZhaWxlZCB0byBmaW5kIFBMTCBm b3IgcGlwZSAlY1xuIiwKPiBAQCAtMTA3MzksNiArMTA4MDMsMjIgQEAgc3RhdGljIGludCBfX2lu dGVsX3NldF9tb2RlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgCQlwcmVwYXJlX3BpcGVzICY9 IH5kaXNhYmxlX3BpcGVzOwo+ICAJfQo+ICAKPiArCWlmIChkZXZfcHJpdi0+ZGlzcGxheS5jcnRj X2NvbXB1dGVfY2xvY2spIHsKPiArCQl1bnNpZ25lZCBjbGVhcl9waXBlcyA9IG1vZGVzZXRfcGlw ZXMgfCBkaXNhYmxlX3BpcGVzOwo+ICsKPiArCQlyZXQgPSBpbnRlbF9zaGFyZWRfZHBsbF9zdGFy dF9jb25maWcoZGV2X3ByaXYsIGNsZWFyX3BpcGVzKTsKPiArCQlpZiAocmV0KQo+ICsJCQlnb3Rv IGRvbmU7Cj4gKwo+ICsJCWZvcl9lYWNoX2ludGVsX2NydGNfbWFza2VkKGRldiwgbW9kZXNldF9w aXBlcywgaW50ZWxfY3J0Yykgewo+ICsJCQlyZXQgPSBkZXZfcHJpdi0+ZGlzcGxheS5jcnRjX2Nv bXB1dGVfY2xvY2soaW50ZWxfY3J0Yyk7Cj4gKwkJCWlmIChyZXQpIHsKPiArCQkJCWludGVsX3No YXJlZF9kcGxsX2Fib3J0X2NvbmZpZyhkZXZfcHJpdik7Cj4gKwkJCQlnb3RvIGRvbmU7Cj4gKwkJ CX0KPiArCQl9Cj4gKwl9CgpNaWdodCBiZSB1c2VmdWwgdG8gc2h1ZmZsZSB0aGlzIGFuZCB0aGUg dmx2LXNwZWNpZmljIGNvZGUgYWJvdmUgaW50byBhIG5ldwppbnRlbF9jb21wdXRlX2dsb2JhbF9j b25maWcga2luZCBvZiBoZWxwZXIgZnVuY3Rpb24uIEJ1dCB0aGF0IGNhbiBiZSBkb25lCmxhdGVy IG9uIEkgdGhpbmsuCi1EYW5pZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIs IEludGVsIENvcnBvcmF0aW9uCis0MSAoMCkgNzkgMzY1IDU3IDQ4IC0gaHR0cDovL2Jsb2cuZmZ3 bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK