From: Christoph Hellwig Subject: Re: [PATCH 2/4] chardev: Increment cdev reference count when i_cdev references it Date: Tue, 4 Nov 2014 10:52:58 +0100 Message-ID: <20141104095258.GB17722@lst.de> References: <1414008853-13200-1-git-send-email-jack@suse.cz> <1414008853-13200-3-git-send-email-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Al Viro , hch@lst.de, linux-fsdevel@vger.kernel.org, LKML To: Jan Kara Return-path: Content-Disposition: inline In-Reply-To: <1414008853-13200-3-git-send-email-jack@suse.cz> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Oct 22, 2014 at 10:14:11PM +0200, Jan Kara wrote: > Currently i_cdev reference to a character device isn't accounted in the > reference count of the character device. This then requires us to track > all references through a list of all inodes referencing a character > device which is somewhat clumsy and requires list_head in each inode in > the system. > > So make i_cdev a reference like any other. Looks good. Reviewed-by: Christoph Hellwig Maybe you can rename the new variable to something like to_put also?