From: Tom Rini Date: Thu, 6 Nov 2014 13:52:39 -0500 Subject: [U-Boot] [net/eth.c:64]: (error) Uninitialized variable: skip_state In-Reply-To: <20141106181255.9A225382347@gemini.denx.de> References: <20141106123723.C832238334C@gemini.denx.de> <20141106164628.GR24724@bill-the-cat> <20141106181255.9A225382347@gemini.denx.de> Message-ID: <20141106185239.GT24724@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Nov 06, 2014 at 07:12:55PM +0100, Wolfgang Denk wrote: > Dear Tom Rini, > > In message <20141106164628.GR24724@bill-the-cat> you wrote: > > > > > [net/eth.c:64]: (error) Uninitialized variable: skip_state > > > > Dense code, like cmd_ini.c my cppcheck is OK and looking at the code > > manually I think it's fine too: > > return ((skip_state = getenv(enetvar)) != NULL); > > Looks OK to me, too, but recent versions of cppcheck spew this error. File a bug back with them then? I do like what cppcheck is doing 'tho, I poked some of the sandbox ones as well and they're real. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: