From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH trivial] xen-hvm: Remove redandant varialbe
 'xstate'
Date: Tue, 11 Nov 2014 09:24:00 -0500
Message-ID: <20141111142359.GB8751@konrad-lan.dumpdata.com>
References: <5461D59C.5020106@gmail.com>
	<alpine.DEB.2.02.1411111052280.26318@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.02.1411111052280.26318@kaball.uk.xensource.com>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, xen-devel@lists.xensource.com, Michael Tokarev <mjt@tls.msk.ru>, Chen Gang <gang.chen.5i5j@gmail.com>, qemu-devel <qemu-devel@nongnu.org>

On Tue, Nov 11, 2014 at 10:53:01AM +0000, Stefano Stabellini wrote:
> On Tue, 11 Nov 2014, Chen Gang wrote:
> > In xen_hvm_change_state_handler(), can pass 'opaque' with type cast to
> > xen_main_loop_prepare() directly, need not use additional variable for
> > it.

The title of your patch should say 'variable'.
> > 
> > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> 
> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> 
> 
> >  xen-hvm.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/xen-hvm.c b/xen-hvm.c
> > index 21f1cbb..7548794 100644
> > --- a/xen-hvm.c
> > +++ b/xen-hvm.c
> > @@ -993,9 +993,8 @@ static void xen_main_loop_prepare(XenIOState *state)
> >  static void xen_hvm_change_state_handler(void *opaque, int running,
> >                                           RunState rstate)
> >  {
> > -    XenIOState *xstate = opaque;
> >      if (running) {
> > -        xen_main_loop_prepare(xstate);
> > +        xen_main_loop_prepare((XenIOState *)opaque);
> >      }
> >  }
> >  
> > -- 
> > 1.8.5.2 (Apple Git-48)
> > 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel