From: Daniel Vetter Subject: Re: [PATCH 3/2] drm/i915: unify remaining register save/restore code a bit Date: Wed, 12 Nov 2014 16:48:14 +0100 Message-ID: <20141112154814.GA25711@phenom.ffwll.local> References: <1415802343-23091-2-git-send-email-jani.nikula@intel.com> <1415804470-3029-1-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by gabe.freedesktop.org (Postfix) with ESMTP id 1B42C6E34C for ; Wed, 12 Nov 2014 07:47:56 -0800 (PST) Received: by mail-wi0-f178.google.com with SMTP id bs8so5294897wib.11 for ; Wed, 12 Nov 2014 07:47:55 -0800 (PST) Content-Disposition: inline In-Reply-To: <1415804470-3029-1-git-send-email-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, shuang.he@linux.intel.com List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBOb3YgMTIsIDIwMTQgYXQgMDU6MDE6MTBQTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gVXNlIHRoZSBzYW1lIGNvbmRpdGlvbnMsIGdyb3VwIGJ5IGZlYXR1cmVzLCBhZGQgY29t bWVudHMuCj4gCj4gU2lnbmVkLW9mZi1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVs LmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9zdXNwZW5kLmMgfCAxOCAr KysrKysrKystLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgOSBk ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9z dXNwZW5kLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3N1c3BlbmQuYwo+IGluZGV4IDNj MWZjY2ZhY2FjMS4uZGZlNjYxNzQzMzk4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfc3VzcGVuZC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9zdXNw ZW5kLmMKPiBAQCAtMjAzLDIxICsyMDMsMTkgQEAgc3RhdGljIHZvaWQgaTkxNV9zYXZlX2Rpc3Bs YXkoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgCQlpOTE1X3NhdmVfZGlzcGxheV9yZWcoZGV2 KTsKPiAgCj4gIAkvKiBMVkRTIHN0YXRlICovCj4gLQlpZiAoSEFTX1BDSF9TUExJVChkZXYpKSB7 Cj4gLQkJZGV2X3ByaXYtPnJlZ2ZpbGUuc2F2ZVBQX0NPTlRST0wgPSBJOTE1X1JFQUQoUENIX1BQ X0NPTlRST0wpOwo+IC0JCWlmIChIQVNfUENIX0lCWChkZXYpIHx8IEhBU19QQ0hfQ1BUKGRldikp Cj4gLQkJCWRldl9wcml2LT5yZWdmaWxlLnNhdmVMVkRTID0gSTkxNV9SRUFEKFBDSF9MVkRTKTsK PiAtCX0gZWxzZSBpZiAoIUlTX1ZBTExFWVZJRVcoZGV2KSkgewo+IC0JCWRldl9wcml2LT5yZWdm aWxlLnNhdmVQUF9DT05UUk9MID0gSTkxNV9SRUFEKFBQX0NPTlRST0wpOwo+IC0JCWlmIChJU19N T0JJTEUoZGV2KSAmJiAhSVNfSTgzMChkZXYpKQo+IC0JCQlkZXZfcHJpdi0+cmVnZmlsZS5zYXZl TFZEUyA9IEk5MTVfUkVBRChMVkRTKTsKPiAtCX0KPiArCWlmIChIQVNfUENIX0lCWChkZXYpIHx8 IEhBU19QQ0hfQ1BUKGRldikpCj4gKwkJZGV2X3ByaXYtPnJlZ2ZpbGUuc2F2ZUxWRFMgPSBJOTE1 X1JFQUQoUENIX0xWRFMpOwo+ICsJZWxzZSBpZiAoSU5URUxfSU5GTyhkZXYpLT5nZW4gPD0gNCAm JiBJU19NT0JJTEUoZGV2KSAmJiAhSVNfSTgzMChkZXYpKQo+ICsJCWRldl9wcml2LT5yZWdmaWxl LnNhdmVMVkRTID0gSTkxNV9SRUFEKExWRFMpOwo+ICAKPiArCS8qIFBhbmVsIHBvd2VyIHNlcXVl bmNlciAqLwo+ICAJaWYgKEhBU19QQ0hfU1BMSVQoZGV2KSkgewo+ICsJCWRldl9wcml2LT5yZWdm aWxlLnNhdmVQUF9DT05UUk9MID0gSTkxNV9SRUFEKFBDSF9QUF9DT05UUk9MKTsKPiAgCQlkZXZf cHJpdi0+cmVnZmlsZS5zYXZlUFBfT05fREVMQVlTID0gSTkxNV9SRUFEKFBDSF9QUF9PTl9ERUxB WVMpOwo+ICAJCWRldl9wcml2LT5yZWdmaWxlLnNhdmVQUF9PRkZfREVMQVlTID0gSTkxNV9SRUFE KFBDSF9QUF9PRkZfREVMQVlTKTsKPiAgCQlkZXZfcHJpdi0+cmVnZmlsZS5zYXZlUFBfRElWSVNP UiA9IEk5MTVfUkVBRChQQ0hfUFBfRElWSVNPUik7Cj4gIAl9IGVsc2UgaWYgKCFJU19WQUxMRVlW SUVXKGRldikpIHsKPiArCQlkZXZfcHJpdi0+cmVnZmlsZS5zYXZlUFBfQ09OVFJPTCA9IEk5MTVf UkVBRChQUF9DT05UUk9MKTsKPiAgCQlkZXZfcHJpdi0+cmVnZmlsZS5zYXZlUFBfT05fREVMQVlT ID0gSTkxNV9SRUFEKFBQX09OX0RFTEFZUyk7Cj4gIAkJZGV2X3ByaXYtPnJlZ2ZpbGUuc2F2ZVBQ X09GRl9ERUxBWVMgPSBJOTE1X1JFQUQoUFBfT0ZGX0RFTEFZUyk7Cj4gIAkJZGV2X3ByaXYtPnJl Z2ZpbGUuc2F2ZVBQX0RJVklTT1IgPSBJOTE1X1JFQUQoUFBfRElWSVNPUik7CgpKdXN0IGJlY2F1 c2UgdGhleSdyZSBpbiB0aGUgY29udGV4dDogRG8gd2Ugc3RpbGwgbmVlZCB0byByZXN0b3JlIHRo ZSBQUApzdHVmZiB3aXRoIGFsbCB0aGUgcmVjZW50IHBwcyBwYXRjaGVzPyBXb3VsZCBiZSBncmVh dCB0byByZW1vdmUgdGhpcyAuLi4KCkFueXdheSBsb29rcyBhbGwgZ29vZCAoYW5kIG5pY2VseSBm cmlndGhlbmluZyA7LSkgc28gcHVsbGVkIGFsbCBpbnRvIGRpbnEuCi1EYW5pZWwKCj4gQEAgLTI0 NiwxMSArMjQ0LDEzIEBAIHN0YXRpYyB2b2lkIGk5MTVfcmVzdG9yZV9kaXNwbGF5KHN0cnVjdCBk cm1fZGV2aWNlICpkZXYpCj4gIAlpZiAoZHJtX2NvcmVfY2hlY2tfZmVhdHVyZShkZXYsIERSSVZF Ul9NT0RFU0VUKSkKPiAgCQltYXNrID0gfkxWRFNfUE9SVF9FTjsKPiAgCj4gKwkvKiBMVkRTIHN0 YXRlICovCj4gIAlpZiAoSEFTX1BDSF9JQlgoZGV2KSB8fCBIQVNfUENIX0NQVChkZXYpKQo+ICAJ CUk5MTVfV1JJVEUoUENIX0xWRFMsIGRldl9wcml2LT5yZWdmaWxlLnNhdmVMVkRTICYgbWFzayk7 Cj4gIAllbHNlIGlmIChJTlRFTF9JTkZPKGRldiktPmdlbiA8PSA0ICYmIElTX01PQklMRShkZXYp ICYmICFJU19JODMwKGRldikpCj4gIAkJSTkxNV9XUklURShMVkRTLCBkZXZfcHJpdi0+cmVnZmls ZS5zYXZlTFZEUyAmIG1hc2spOwo+ICAKPiArCS8qIFBhbmVsIHBvd2VyIHNlcXVlbmNlciAqLwo+ ICAJaWYgKEhBU19QQ0hfU1BMSVQoZGV2KSkgewo+ICAJCUk5MTVfV1JJVEUoUENIX1BQX09OX0RF TEFZUywgZGV2X3ByaXYtPnJlZ2ZpbGUuc2F2ZVBQX09OX0RFTEFZUyk7Cj4gIAkJSTkxNV9XUklU RShQQ0hfUFBfT0ZGX0RFTEFZUywgZGV2X3ByaXYtPnJlZ2ZpbGUuc2F2ZVBQX09GRl9ERUxBWVMp Owo+IC0tIAo+IDIuMS4xCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRl bCBDb3Jwb3JhdGlvbgorNDEgKDApIDc5IDM2NSA1NyA0OCAtIGh0dHA6Ly9ibG9nLmZmd2xsLmNo Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==