From: Wolfgang Denk Date: Thu, 13 Nov 2014 13:20:52 +0100 Subject: [U-Boot] arm: socfpga: set skew settings for ethernet phy In-Reply-To: <20141113120956.GB30779@amd> References: <1415738748-3907-1-git-send-email-dinguyen@opensource.altera.com> <20141113120956.GB30779@amd> Message-ID: <20141113122052.967EB382304@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Pavel Machek, In message <20141113120956.GB30779@amd> you wrote: > > diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c > index 507b9a3..06a31b0 100644 > --- a/drivers/net/phy/micrel.c > +++ b/drivers/net/phy/micrel.c > @@ -112,17 +112,46 @@ static int ksz9021_phy_extwrite(struct phy_device *phydev, int addr, > return ksz9021_phy_extended_write(phydev, regnum, val); > } > > + > + Please don't add excessive white space / blank lines. > + printf("ksz9021: configuring\n"); > + > + printf("Configuring PHY skew timing for %s\n", > + phydev->drv->name); Should these eventually be changed into debug() ? Output gets really noisy otherwise. > if (getenv("disable_giga")) Should we not rather use the standard "hwconf" approach here? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de There is a time in the tides of men, Which, taken at its flood, leads on to success. On the other hand, don't count on it. - T. K. Lawson