From: Wolfgang Denk <wd@denx.de>
Date: Fri, 14 Nov 2014 14:23:46 +0100
Subject: [U-Boot] [PATCH] mcf: Fix cppcheck errors about uninitialized
	variables
In-Reply-To: <20141114134733.01c82023@lilith>
References: <1415948172-41691-1-git-send-email-b18965@freescale.com>
	<20141114134733.01c82023@lilith>
Message-ID: <20141114132346.C290C382CC5@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Albert,

In message <20141114134733.01c82023@lilith> you wrote:
> 
> > -	u8 bootmode;
> > +	u8 bootmode = 0;
> 
> If you set bootmode to the default 0 value at declaration, then the code
> that follows in the source file can be simplified:
> 
> 	u8 bootmode = 0;
> ---8<---
> 	pcrvalue = in_be32(&pll->pcr) & 0xFF0F0FFF;
> 	pfdr = pcrvalue >> 24;
> 
> 	if (pfdr == 0x1E)
> 		bootmode = 0;	/* Normal Mode */
> ---8<---
> 
> The part between scissors is useless now, and in turn, pfdr becomes unneeded.

Exactly.  This was my concern, too - otherwise I had provided auch a
trivial fix.  But I think here some deeper understanding of the
intended logic is needed.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Brain: an apparatus with which we think we think.    - Ambrose Bierce