From: Ingo Molnar Subject: Re: [PATCH V6 00/18] x86: Full support of PAT Date: Sun, 16 Nov 2014 14:08:47 +0100 Message-ID: <20141116130847.GA4736@gmail.com> References: <1415019724-4317-1-git-send-email-jgross@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1415019724-4317-1-git-send-email-jgross@suse.com> Sender: linux-kernel-owner@vger.kernel.org To: Juergen Gross Cc: hpa@zytor.com, x86@kernel.org, tglx@linutronix.de, mingo@redhat.com, stefan.bader@canonical.com, linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com, konrad.wilk@oracle.com, ville.syrjala@linux.intel.com, david.vrabel@citrix.com, jbeulich@suse.com, toshi.kani@hp.com, plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, bhelgaas@google.com List-Id: xen-devel@lists.xenproject.org * Juergen Gross wrote: > arch/x86/include/asm/cacheflush.h | 38 ++++--- =46YI, this series breaks the UML build: In file included from /home/mingo/tip/include/linux/highmem.h:11:0, from /home/mingo/tip/include/linux/pagemap.h:10, from /home/mingo/tip/include/linux/mempolicy.h:14, from /home/mingo/tip/include/linux/shmem_fs.h:6, from /home/mingo/tip/init/do_mounts.c:30: /home/mingo/tip/arch/x86/include/asm/cacheflush.h:67:36: error: return = type is an incomplete type static inline enum page_cache_mode get_page_memtype(struct page *pg) ^ /home/mingo/tip/arch/x86/include/asm/cacheflush.h: In function =E2=80=98= get_page_memtype=E2=80=99: /home/mingo/tip/arch/x86/include/asm/cacheflush.h:69:2: warning: =E2=80= =98return=E2=80=99 with a value, in function returning void [enabled by= default] return -1; ^ /home/mingo/tip/arch/x86/include/asm/cacheflush.h: At top level: /home/mingo/tip/arch/x86/include/asm/cacheflush.h:72:30: error: paramet= er 2 (=E2=80=98memtype=E2=80=99) has incomplete type enum page_cache_mode memtype) ^ /home/mingo/tip/arch/x86/include/asm/cacheflush.h:71:20: error: functio= n declaration isn=E2=80=99t a prototype [-Werror=3Dstrict-prototypes] Thanks, Ingo