Received: from eggs.gnu.org ([2001:4830:134:3::10]:40299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XvoxN-0002s4-Mv for qemu-devel@nongnu.org; Tue, 02 Dec 2014 10:01:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XvoxH-0000WP-Iw for qemu-devel@nongnu.org; Tue, 02 Dec 2014 10:01:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35369) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XvoxH-0000W7-BA for qemu-devel@nongnu.org; Tue, 02 Dec 2014 10:01:31 -0500 Date: Tue, 2 Dec 2014 15:01:17 +0000 From: Stefan Hajnoczi Message-ID: <20141202150117.GA12390@stefanha-thinkpad.redhat.com> References: <1417177867-27918-1-git-send-email-fromani@redhat.com> <1417177867-27918-2-git-send-email-fromani@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8t9RHnE3ZwKMSgU+" Content-Disposition: inline In-Reply-To: <1417177867-27918-2-git-send-email-fromani@redhat.com> Subject: Re: [Qemu-devel] [PATCHv3] block: add event when disk usage exceeds threshold List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Francesco Romani Cc: kwolf@redhat.com, mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org, lcapitulino@redhat.com --8t9RHnE3ZwKMSgU+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 28, 2014 at 01:31:07PM +0100, Francesco Romani wrote: > @@ -82,6 +83,8 @@ BlockDeviceInfo *bdrv_block_device_info(BlockDriverStat= e *bs) > info->iops_size =3D cfg.op_size; > } > =20 > + info->write_threshold =3D bdrv_usage_threshold_get(bs); Overall looks good but I notice that "write_threshold" and "usage_threshold" are both used. Please use just one consistently (I think "write_threshold" is clearer). --8t9RHnE3ZwKMSgU+ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUfdQ9AAoJEJykq7OBq3PIN5IH/2WYpmK2g1Lh6t/vp+4YNqXT IEk069u1x2Ad3NyJAkxhPsea0kIRfo5/BTsSMCp1SCy5nhSCgMSXaxcbTgY8P00e 4Q92bsSge6XckRaeyhUKaDBtyHVifdU3aVSbgdwGfFft3oYKD1VAx5ggQFErY8l7 j3N6J3k6GQITkv7VDsJFLxDkjZ3nK0SIITJQC6Jym4VJTpyySjJfN9PpoD57Bwzy HI+lu4G8dC+SXzpVbJhdGZXtumReyT4XNnpWI+3oSsgzJeO6/uiV3dwBcFXoAXD1 zbvn1kphY3rsRfyT5UfdQxFp3H2SdTjhrhwftMIZQjF2UOVSJUpkpglhOoIcOD8= =u2i6 -----END PGP SIGNATURE----- --8t9RHnE3ZwKMSgU+--