From: Daniel Vetter Subject: Re: [PATCH 1/2] drm: Fix memory leak at error path of drm_read() Date: Thu, 4 Dec 2014 13:28:39 +0100 Message-ID: <20141204122839.GE20350@phenom.ffwll.local> References: <1417690603-1595-1-git-send-email-tiwai@suse.de> <20141204115114.GB13586@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 542E96E5FF for ; Thu, 4 Dec 2014 04:28:11 -0800 (PST) Received: by mail-wi0-f177.google.com with SMTP id l15so27704859wiw.4 for ; Thu, 04 Dec 2014 04:28:10 -0800 (PST) Content-Disposition: inline In-Reply-To: <20141204115114.GB13586@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Wilson , Takashi Iwai , dri-devel@lists.freedesktop.org, Maarten Lankhorst List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBEZWMgMDQsIDIwMTQgYXQgMTE6NTE6MTRBTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IE9uIFRodSwgRGVjIDA0LCAyMDE0IGF0IDExOjU2OjQyQU0gKzAxMDAsIFRha2FzaGkg SXdhaSB3cm90ZToKPiA+IFNpZ25lZC1vZmYtYnk6IFRha2FzaGkgSXdhaSA8dGl3YWlAc3VzZS5k ZT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZm9wcy5jIHwgMSArCj4gPiAgMSBm aWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vZHJtX2ZvcHMuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZm9wcy5jCj4gPiBpbmRl eCBlZDdiYzY4ZjdlODcuLmE4MmRjMjhkNTRmMyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9kcm1fZm9wcy5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZvcHMuYwo+ID4g QEAgLTUyNSw2ICs1MjUsNyBAQCBzc2l6ZV90IGRybV9yZWFkKHN0cnVjdCBmaWxlICpmaWxwLCBj aGFyIF9fdXNlciAqYnVmZmVyLAo+ID4gIAkJaWYgKGNvcHlfdG9fdXNlcihidWZmZXIgKyB0b3Rh bCwKPiA+ICAJCQkJIGUtPmV2ZW50LCBlLT5ldmVudC0+bGVuZ3RoKSkgewo+ID4gIAkJCXRvdGFs ID0gLUVGQVVMVDsKPiA+ICsJCQllLT5kZXN0cm95KGUpOwo+IAo+IFdlIHNob3VsZG4ndCBqdXN0 IGJlIHRocm93aW5nIGF3YXkgdGhlIGV2ZW50IGhlcmUsIGJ1dCBwdXQgdGhlIGV2ZW50Cj4gYmFj ayBhdCB0aGUgZnJvbnQgb2YgdGhlIHF1ZXVlLiBQb3NlcyBhbiBpbnRlcmVzdGluZyByYWNlIGlz c3VlLiBTZWVtcwo+IGxpa2Ugd2Ugd2FudCB0byBob2xkIHRoZSBzcGlubG9jayB1bnRpbCB0aGUg Y29weSBpcyBjb21wbGV0ZSBzbyB0aGF0IHdlCj4gY2FuIGZpeCB1cCB0aGUgZmFpbHVyZSBjb3Jy ZWN0bHkuCgpJJ3ZlIHJlYWQgdGhlIG1hbnBhZ2UgZm9yIHJlYWQgYW5kIGl0IGV4cGxpY2l0bHkg c3RhdGVzIHRoYXQgd2hlbiB5b3UgZ2V0CmFuIGVycm9yIGl0J3MgdW5kZWZpbmVkIHdoYXQgaGFw cGVucyB0byB0aGUgcmVhZCBwb3NpdGlvbi4gU2luY2UgLUVGQVVMVAppcyByZWFsbHkganVzdCBh IHVzZXJzcGFjZSBidWcgSSB0aGluayB3ZSBjYW4gaGFwcGlseSBkcm9wIHRoZSBldmVudCBvbgp0 aGUgZmxvb3IsIG5vIHJlYXNvbiB0byBiZW5kIG92ZXIgaW4gdGhlIGtlcm5lbC4KCkknbGwgYWRk IGEgbm90ZSB0byB0aGUgY29tbWl0IG1lc3NhZ2UuCi1EYW5pZWwKLS0gCkRhbmllbCBWZXR0ZXIK U29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCis0MSAoMCkgNzkgMzY1IDU3IDQ4 IC0gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWwK