From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Clean the request structure on alloc Date: Fri, 5 Dec 2014 21:44:35 +0100 Message-ID: <20141205204434.GW20350@phenom.ffwll.local> References: <1417802083-4695-1-git-send-email-mika.kuoppala@intel.com> <5481F158.7040202@Intel.com> <5481F33B.1070100@Intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51]) by gabe.freedesktop.org (Postfix) with ESMTP id C17406E13A for ; Fri, 5 Dec 2014 12:44:04 -0800 (PST) Received: by mail-wg0-f51.google.com with SMTP id k14so1843071wgh.38 for ; Fri, 05 Dec 2014 12:44:04 -0800 (PST) Content-Disposition: inline In-Reply-To: <5481F33B.1070100@Intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: John Harrison Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBEZWMgMDUsIDIwMTQgYXQgMDY6MDI6MzVQTSArMDAwMCwgSm9obiBIYXJyaXNvbiB3 cm90ZToKPiBCdXQgeWVzLCB0aGUgcmVhc29uaW5nIHdoeSBpdCBjcmFzaGVzIHdpdGhvdXQgdGhl IHplcm8gZmlsbCBpcyBjb3JyZWN0Lgo+IERvZGd5IGNvbnRleHQgcG9pbnRlcnMgdGhhdCB1c2Vk IHRvIGJlIGlnbm9yZWQgbm93IGdldCBwcm9jZXNzZWQuIERvaW5nIHRoZQo+IHplcm8gZmlsbCBr ZWVwcyBpdCBhbGwgc2FuZS4KPiAKPiBPbiAwNS8xMi8yMDE0IDE3OjU0LCBKb2huIEhhcnJpc29u IHdyb3RlOgo+ID5UaGlzIGlzIGFscmVhZHkgcGFydCBvZiB0aGUgc2Vxbm8vcmVxdWVzdCBwYXRj aCBzZXJpZXMgYW5kIGhhcyBiZWVuIHJpZ2h0Cj4gPmZyb20gdGhlIHN0YXJ0LiBTZWUgZW1haWwg J2RybS9pOTE1OiBaZXJvIGZpbGwgdGhlIHJlcXVlc3Qgc3RydWN0dXJlJy4KPiA+Cj4gPk9uIDA1 LzEyLzIwMTQgMTc6NTQsIE1pa2EgS3VvcHBhbGEgd3JvdGU6Cj4gPj5PdGhlcndpc2Ugd2UgbWln aHQgZW5kIHVwIHJlZmVyZW5jaW5nIHVuaW5pdGlhbGl6ZWQgZmllbGRzLgo+ID4+VGhpcyBpcyBh cHBhcmVudCB3aGVuIHdlIHRyeSB0byBjbGVhbnVwIHRoZSBwcmVhbGxvY2F0ZWQgcmVxdWVzdAo+ ID4+b24gcmluZyByZXNldCwgYmVmb3JlIGFueSByZXF1ZXN0IGhhcyBiZWVuIHN1Ym1pdHRlZCB0 byB0aGUgcmluZy4KPiA+PlRoZSByZXF1ZXN0LT5jdHggaXMgZm9vYmFyIGFuZCB3ZSBlbmQgdXAg ZnJlZWluZyB0aGUgZm9vYmFybmVzcy4KPiA+Pgo+ID4+UmVmZXJlbmNlczogaHR0cHM6Ly9idWdz LmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODY5NTkKPiA+PlJlZmVyZW5jZXM6IGh0 dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTg2OTYyCj4gPj5SZWZl cmVuY2VzOiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD04Njk5 Mgo+ID4+Q2M6IEpvaG4gSGFycmlzb24gPEpvaG4uQy5IYXJyaXNvbkBJbnRlbC5jb20+Cj4gPj5T aWduZWQtb2ZmLWJ5OiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGludGVsLmNvbT4KCkkn dmUgYWRkZWQgdGhpcyBleHBsYW5hdGlvbiBwbHVzIHRoZSBub3RlIGFib3V0IHdoaWNoIGNvbW1p dCBpbnRyb2R1Y2VkCnRoZSByZWdyZXNzaW9uIHRvIEpvaG4ncyBwYXRjaCBhbmQgbWVyZ2VkIHRo YXQgb25lLgoKVGhhbmtzIGZvciB0cmFja2luZyB0aGlzIGRvd24uCi1EYW5pZWwKCj4gPj4tLS0K PiA+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jIHwgMiArLQo+ID4+ ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPiA+Pgo+ID4+ ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYwo+ID4+ Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMKPiA+PmluZGV4IDc5YjRj YTUuLjJjNmM2ZjggMTAwNjQ0Cj4gPj4tLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9y aW5nYnVmZmVyLmMKPiA+PisrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZm ZXIuYwo+ID4+QEAgLTIwMzAsNyArMjAzMCw3IEBAIGludGVsX3JpbmdfYWxsb2NfcmVxdWVzdChz dHJ1Y3QgaW50ZWxfZW5naW5lX2NzCj4gPj4qcmluZykKPiA+PiAgICAgIGlmIChyaW5nLT5vdXRz dGFuZGluZ19sYXp5X3JlcXVlc3QpCj4gPj4gICAgICAgICAgcmV0dXJuIDA7Cj4gPj4gIC0gICAg cmVxdWVzdCA9IGttYWxsb2Moc2l6ZW9mKCpyZXF1ZXN0KSwgR0ZQX0tFUk5FTCk7Cj4gPj4rICAg IHJlcXVlc3QgPSBremFsbG9jKHNpemVvZigqcmVxdWVzdCksIEdGUF9LRVJORUwpOwo+ID4+ICAg ICAgaWYgKHJlcXVlc3QgPT0gTlVMTCkKPiA+PiAgICAgICAgICByZXR1cm4gLUVOT01FTTsKPiA+ Cj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJ bnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK Ci0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgor NDEgKDApIDc5IDM2NSA1NyA0OCAtIGh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==